From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 384C2C433DF for ; Thu, 27 Aug 2020 03:54:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1AE0D20786 for ; Thu, 27 Aug 2020 03:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726938AbgH0DyL (ORCPT ); Wed, 26 Aug 2020 23:54:11 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:10268 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726804AbgH0DyK (ORCPT ); Wed, 26 Aug 2020 23:54:10 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 55A1047872667942D41D; Thu, 27 Aug 2020 11:54:08 +0800 (CST) Received: from [127.0.0.1] (10.174.179.108) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 11:54:05 +0800 Subject: Re: [PATCH] libnvdimm/e820: Fix build error without MEMORY_HOTPLUG To: , , , , References: <20200826121800.732-1-yuehaibing@huawei.com> CC: , From: Yuehaibing Message-ID: Date: Thu, 27 Aug 2020 11:54:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20200826121800.732-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pls ignore this It has be fixed in commit dbb8733abb1c ("mm-memory_hotplug-introduce-default-phys_to_target_node-implementation-fix") On 2020/8/26 20:18, YueHaibing wrote: > If MEMORY_HOTPLUG is n, build fails: > > drivers/nvdimm/e820.c: In function ‘e820_register_one’: > drivers/nvdimm/e820.c:24:12: error: implicit declaration of function ‘phys_to_target_node’; did you mean ‘set_page_node’? [-Werror=implicit-function-declaration] > int nid = phys_to_target_node(res->start); > ^~~~~~~~~~~~~~~~~~~ > set_page_node > > Fixes: 7b27a8622f80 ("libnvdimm/e820: Retrieve and populate correct 'target_node' info") > Signed-off-by: YueHaibing > --- > drivers/nvdimm/e820.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/nvdimm/e820.c b/drivers/nvdimm/e820.c > index 4cd18be9d0e9..c741f029f215 100644 > --- a/drivers/nvdimm/e820.c > +++ b/drivers/nvdimm/e820.c > @@ -17,6 +17,13 @@ static int e820_pmem_remove(struct platform_device *pdev) > return 0; > } > > +#ifndef CONFIG_MEMORY_HOTPLUG > +static inline int phys_to_target_node(u64 start) > +{ > + return 0; > +} > +#endif > + > static int e820_register_one(struct resource *res, void *data) > { > struct nd_region_desc ndr_desc; >