mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: Peter Xu <peterx@redhat.com>
Cc: Axel Rasmussen <axelrasmussen@google.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Muchun Song <songmuchun@bytedance.com>,
	Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/hugetlb: avoid corrupting page->mapping in hugetlb_mcopy_atomic_pte
Date: Fri, 15 Jul 2022 10:50:32 +0800	[thread overview]
Message-ID: <c1b7243c-563f-b260-2a52-f157cf51f080@huawei.com> (raw)
In-Reply-To: <YtA6GcRwP7iiJScG@xz-m1.local>

On 2022/7/14 23:45, Peter Xu wrote:
> On Thu, Jul 14, 2022 at 06:09:49PM +0800, Miaohe Lin wrote:
>> As discussed in another thread, we might call page_dup_file_rmap for newly
>> allocated page (regardless of this patch). So should we come up a seperate
>> patch to call page_add_file_rmap here instead?
> 
> Hmm, why we need page_add_file_rmap() even if a new page allocated?  Say,
> we're at least also using page_dup_file_rmap() in hugetlb_no_page().
> 
> I see majorly two things extra there: memcg accounts on NR_FILE_MAPPED, and
> mlock.  But I assume both of them will not apply to hugetlb pages?

I think you are right. PageDoubleMap is also irrelevant for hugetlb.
page_add_file_rmap shouldn't be called for hugetlb page. It seems
page_dup_file_rmap can be regarded as hugetlb variant of page_add_file_rmap.
Sorry for making noise.

> 

Thanks.

  reply	other threads:[~2022-07-15  2:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12 13:05 Miaohe Lin
2022-07-12 17:39 ` Mike Kravetz
2022-07-13  2:10   ` Miaohe Lin
2022-07-13 14:24   ` Peter Xu
2022-07-13 16:10     ` Peter Xu
2022-07-13 22:46       ` Axel Rasmussen
2022-07-13 23:36         ` Mike Kravetz
2022-07-14  0:20           ` Axel Rasmussen
2022-07-14 10:09             ` Miaohe Lin
2022-07-14 15:45               ` Peter Xu
2022-07-15  2:50                 ` Miaohe Lin [this message]
2022-07-13 17:23 ` Andrew Morton
2022-07-14  9:59   ` Miaohe Lin
2022-07-14 15:52     ` Peter Xu
2022-07-15  3:56       ` Miaohe Lin
2022-07-15 12:35         ` Peter Xu
     [not found]           ` <CAJHvVcgFY2uXM=CkxYmHc32Vqb5qmr8vFv0dpFk-2=Ef+Kssqw@mail.gmail.com>
2022-07-15 17:07             ` Peter Xu
2022-07-15 17:28               ` Axel Rasmussen
2022-07-15 17:39                 ` Peter Xu
2022-07-15 17:51                   ` Axel Rasmussen
2022-07-16  1:32                     ` Miaohe Lin
2022-07-15 17:29               ` Mike Kravetz
2022-07-15 17:38                 ` Peter Xu
2022-07-16 23:06     ` Andrew Morton
2022-07-18  2:25       ` Miaohe Lin
2022-07-18 18:07         ` Axel Rasmussen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1b7243c-563f-b260-2a52-f157cf51f080@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=peterx@redhat.com \
    --cc=songmuchun@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®