From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D554941D115 for ; Fri, 14 Aug 2026 07:42:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786693368; cv=none; b=sZL6yJc1XExYyocaclmOQIheW6GJMFvjhFMK1qMyr8TrmjNeBWyYJrA990pyqMwfrW+dCsiYIBsU3t3unoeUDNjKMteXLnqmcLti64K6bFVYqXTb9Dn06KoTyYouB+tyvUCfOft5Oiyy9Bn4OtPpXxbhj6T65r8NerQhNk+IzuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786693368; c=relaxed/simple; bh=yQK6BU/jG8kZpwu5by/foagCc8x9efnKwLqHq52D3Yw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DyrsiNQg1i6XmXxm0W7CO1XNd+FQO6ZFN2/mhhJBEAAGg2PWJj57H8hTV7d/Gh7EwX/DSy3SMDpabxzFq0owGuCielzhBYFMAoVt5nHgN9rhMxIAtqYOCMLpcSlt47ocHq0w1fyKCPcz6ZViCl4mE0nHDxbAdQhgoapSB9XQq4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EiQnZT4g; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D+y6Eu2/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EiQnZT4g"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D+y6Eu2/" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67E7fkac736489 for ; Fri, 14 Aug 2026 07:42:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WBklc2G/busGjck73g0DPLTntqH4yid2WXdPSTnv2u0=; b=EiQnZT4gbhHaU+Pj kF96ZKDTJmzdLV0vYK4mDYhAiCUq/KsWIwMgBHFiTSDy2UzLQQA2b5OHgCippIZo uJYs+Z7DBuUokITFWg9iE45+ysRERVWegCOUoS9kKQdkHzszk3wMd2eZi05WiB6+ m9ROl4CNEPZKng+17KrJTpQ9/pzwXrKdEiKYh2GAudIxxBl5GWI7QI3XxN4OU+D9 tCjfqp02HD7neJMTQ8G5zrk60pyHjjoPys2HfwW6GMgYE1NRcQ0qNqCWS8nzacUD 4anmEftPIjTM95ie1469AyH5FgW7lto/+qYOQd4pwpRyqHHvdjsTvElfxFrEK8Ez LarB5w== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1j2f2yt8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 14 Aug 2026 07:42:39 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cbedf6e8a42so824797a12.1 for ; Fri, 14 Aug 2026 00:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786693358; x=1787298158; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WBklc2G/busGjck73g0DPLTntqH4yid2WXdPSTnv2u0=; b=D+y6Eu2/qDFIqMgjVlNpVmrw/je4jW5z6Am961uQxgSV66G/2sgOWkygPIiy4m39zn lYLl08SBYGEv66Ye4A/ESuRjC+r4zIneTDn5+rtcmvCpbtOzMjI5qAaZ4q5vNasIt2yR QQs+VxTHU6vypoz/Hs9RzCRquinzsn36FirUdPQzbE9POOAXJumuizGx0HcT9mv4vOVR NLMjOUwQ25dOCpTf/SmD/cbbm0P1Bxjb+Bpc0tIVXE3PR8pDYxgW9Te32NcUVlCu0XtW R0V/8ATjrdaEi3FTociWiUJsIMfwz32Dnk/qZBRuJvk8kw7c1A0MkEZlQvAW6Pu8Oee0 x56w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786693358; x=1787298158; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WBklc2G/busGjck73g0DPLTntqH4yid2WXdPSTnv2u0=; b=o+qCT9CdPUGXMjKv/zZ8ADL2CMztVLV+4dhfp5lhxAwZtA9ZDShQFwnuN2wajAUhNq 576zbzRKak3bvn4Y4L1gH7qqbn6vy2Mj4t+wpPtIw88btCX8wQQl1eotU5TtcmaQM+9z CRj4bmjElHG7jqOZiPk3Q4qJsd2cGp8hMiTri1xRtXoXAxGyvl2j/zLx17DEDjMCCnAv W5Mz5ILU+vbxAznHp2hK8bmoNXN1HX5DoUDMws1q4sBSplADzeaeYdyT/1NkGjp9otAD ioBXyyGgB8UiiY9BBSgUkxbxqa4BNd5o35BJep/BsYC4sKYk++HCfIrC1Wohdg0t+F0i r4Dw== X-Forwarded-Encrypted: i=1; AHgh+RqqJu6jyssLgU9tc9fMRz+g0VCfpiDVGztjmihQ33Sd7ijComgX2vikNxe2ewz0AIzsA0x2HsKeIO7Ebqw=@vger.kernel.org X-Gm-Message-State: AOJu0YyRdHra/YpgZczm27VCqguJFpREo261283+Lk1mCXJnIR41SKSw p5zw8OtjRyP7hCKaHOk1TD88gplkBHaYm5pKbi1puxVlEtRZHSj5v8sVfeRVLUxFWUr7RliLIvq xMHDQ5CEPs35ezDvDdHpDX0ZOjneEZh76y/Dw3JAqrn2nhSszcfRLHQ/ccP4PZx01xsU= X-Gm-Gg: AR+sD12EluV0wwWe2dcqE+LsvrjFBkKuI0PCgzSe/ofxgYNdlfLERVbz+wS33OTok1I jeo23KFF49KT9leN2DzdLUtr8ln6g3R5AsFxaK8s/KZPOrcZPzhMjEWwlsh6HkRA6LXEs7Ih7kR f5ArNoqJ19FrOzO/8xj1N/mWsgyQ9Tcte30ovmYw1I+qO6KOpE5TorRWG2PwVnov2rH9EjZtzto butHZgdoryXlSWNK3z+GNiKW3q4EgPHI4GE6GMmf9uKZ671TD3M35XYgy+O+YQnUw2kNaEfXIZa DoajmsmfQilGRb076TW1D2cngDOm3OFsXyxeR0AtPCEEwLz/Tpauv0cRDHp3Ko3Mv2LR3vg4fuP SIkGwybihn8zmb0scHK4nRwbOCQhR8HHPsYsIuYbejTUA4tCAm+AR3lh7Y7QpKbvlGZxBmBE6fp kwMK+QAMTM3rJLRHjHEN0= X-Received: by 2002:a05:6a20:3c8f:b0:3c3:b57b:627d with SMTP id adf61e73a8af0-3cc71b83e99mr4271593637.12.1786693358530; Fri, 14 Aug 2026 00:42:38 -0700 (PDT) X-Received: by 2002:a05:6a20:3c8f:b0:3c3:b57b:627d with SMTP id adf61e73a8af0-3cc71b83e99mr4271542637.12.1786693358103; Fri, 14 Aug 2026 00:42:38 -0700 (PDT) Received: from [10.79.117.20] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc095a3f9cfsm136922a12.27.2026.08.14.00.42.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2026 00:42:37 -0700 (PDT) Message-ID: Date: Fri, 14 Aug 2026 13:12:29 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/15] clk: qcom: Add Global Clock Controller driver for Kuno To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Michael Turquette , Stephen Boyd , Brian Masney , Taniya Das , Georgi Djakov , Bartosz Golaszewski , Linus Walleij , Thomas Gleixner , Radu Rendec , Robert Marko , Guru Das Srinagesh , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260809-kuno-soc-support-v1-0-5e0ede4a0c72@oss.qualcomm.com> <20260809-kuno-soc-support-v1-11-5e0ede4a0c72@oss.qualcomm.com> Content-Language: en-US From: Hardeep Sharma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=FeMHAp+6 c=1 sm=1 tr=0 ts=6a7ec6ef cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=EkQsDeFWBQwVCp19dG4A:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: sK1uuib-e3A330JNyB0hxslxXKt2wis- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE0MDA1OSBTYWx0ZWRfX2a1E6nHV/LuD tdGN5YBlxo02svjeFGUXsdCBpTUAx4YUnEjokItbcAH9Uid+QfQLfq2kuy0gG5zNZrSVUniP0KA zSr9CJO8JkddBlHUeS98e4DkU9QgpnD3UwFONQNNvc3iWi/7lIDDHbFW02/OjL9cRHq90SKBxZk v7PzPqxuwvK/YeWpMbyQYZ4q9Fj2Z+OqJJK8lQNq+8H/Qw8om/OFEBPWSWaUyBZ3jkZwviueva5 XuQAh0z31UdWTIXg3YNVO/xSZDKEh81tXvpAWbqV+AAhbonpeNbGNMg2Vv8LhTBUvhdistE1mg/ 9/ROWfOCiWW96rI8ee6jxF8nHz9+N5dX6etByzDLcvnVCbjf7/+V1r0LcLjoPhFv8TxgvO+WAxj X+hv42NCf7LoBDeyd0DPp5tIEFRPQX2pwu2KDhUnW7vzho1iNHzphNpIWSwRyEyvGHBWjmcz5/v Xne2NMONgXEGxMyvU5Q== X-Proofpoint-ORIG-GUID: sK1uuib-e3A330JNyB0hxslxXKt2wis- X-Proofpoint-Spam-Info: AW1haW4tMjYwODE0MDA1OSBTYWx0ZWRfX5J53NXfDnbWI MTG8RpyaL9yOQy7U/zPXLmIxAYrbgnB9X/LqtP4LNQF4lAjkGRdROd4DPQjJQRrtNVxVb4t/Wzq aD/fbIovMLXdIgn4ny8iaMjkmEWZ5Jk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-14_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608140059 On 8/11/2026 6:36 AM, Dmitry Baryshkov wrote: > On Sun, Aug 09, 2026 at 12:57:10PM +0530, Hardeep Sharma wrote: >> Add the global clock controller (GCC) driver for the Qualcomm Kuno SoC, >> providing the PLLs, root clock generators, gate/branch clocks and resets >> used by the peripheral devices such as UART, SPI, I2C, USB, SD, PCIe and >> Ethernet. >> >> Signed-off-by: Hardeep Sharma >> --- >> drivers/clk/qcom/Kconfig | 10 + >> drivers/clk/qcom/Makefile | 1 + >> drivers/clk/qcom/gcc-kuno.c | 1438 +++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 1449 insertions(+) >> >> +static struct clk_alpha_pll gpll0 = { >> + .offset = 0x0, >> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID_EVO], >> + .clkr = { >> + .enable_reg = 0x7d000, >> + .enable_mask = BIT(0), >> + .hw.init = &(const struct clk_init_data){ >> + .name = "gpll0", >> + .parent_data = &(const struct clk_parent_data){ > Whitespace between ) and { (through all the file). > >> + .index = DT_BI_TCXO, >> + }, >> + .num_parents = 1, >> + .ops = &clk_alpha_pll_fixed_lucid_evo_ops, >> + }, >> + }, >> +}; >> + Thanks for review. Done in v2 : https://lore.kernel.org/all/20260814-kuno-soc-support-v2-0-3079794f0f73@oss.qualcomm.com/ Best Wishes Hardeep Sharma