From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
Daniel Oliveira Nascimento <don@syst.com.br>,
Mattia Dongili <malattia@linux.it>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javierm@redhat.com>
Subject: Re: [PATCH 1/3] platform: olpc: mark SPI related data as maybe unused
Date: Thu, 16 Mar 2023 15:17:14 +0100 [thread overview]
Message-ID: <c1bc0a26-bdd2-c946-df20-76d169d88c38@linaro.org> (raw)
In-Reply-To: <51d9b1de-5f22-2085-1d3e-6c29afb44120@redhat.com>
On 16/03/2023 15:13, Hans de Goede wrote:
>
> Looks like your right, the spi_uevent() code always emits "spi:xxxxxxx" style modalias even for dt/of enumerated devices:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi.c#n398
>
> So the table needs to stay.
>
> Can you do a v2 (of just this patch) adding an id_table entry to olpc_xo175_ec_spi_driver rather then using __maybe_unused ?
Yes, sure.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-16 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 13:26 Krzysztof Kozlowski
2023-03-12 13:26 ` [PATCH 2/3] platform: classmate: " Krzysztof Kozlowski
2023-03-16 15:14 ` Hans de Goede
2023-03-12 13:26 ` [PATCH 3/3] platform: sony: " Krzysztof Kozlowski
2023-03-16 12:50 ` [PATCH 1/3] platform: olpc: " Hans de Goede
2023-03-16 14:07 ` Krzysztof Kozlowski
2023-03-16 14:13 ` Hans de Goede
2023-03-16 14:17 ` Krzysztof Kozlowski [this message]
2023-03-16 17:31 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1bc0a26-bdd2-c946-df20-76d169d88c38@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=cascardo@holoscopio.com \
--cc=don@syst.com.br \
--cc=hdegoede@redhat.com \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=malattia@linux.it \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®