From: "Ed Swierk" <eswierk@arastra.com>
To: "Greg KH" <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: [RETRY] [PATCH] load_module: no BUG if module_subsys uninitialized
Date: Wed, 27 Sep 2006 12:10:26 -0700 [thread overview]
Message-ID: <c1bf1cf0609271210o5958e39y94e033b478e979f5@mail.gmail.com> (raw)
In-Reply-To: <20060927045611.GC32644@kroah.com>
On 9/26/06, Greg KH <greg@kroah.com> wrote:
> So, with this patch the module will still not be loaded properly, right?
> Well, I guess at least we don't oops... ok.
Correct. sys_init_module() ends up returning an error to
/sbin/modprobe, which trickles down to request_module() if it was
invoked via kmod. The module doesn't get loaded, but at least the
error message states which module it is, and as you say, at least we
don't oops.
I think that not oopsing is pretty important in a case where a goofy
but technically valid configuration (compiling Unix sockets as a
module, and trying to boot with a rootfs containing a version of
/sbin/hotplug that requires Unix sockets) collides with an obscure
kernel implementation detail (initcall ordering).
--Ed
prev parent reply other threads:[~2006-09-27 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 19:48 Ed Swierk
2006-09-22 20:16 ` Greg KH
2006-09-22 21:28 ` Ed Swierk
2006-09-27 4:56 ` Greg KH
2006-09-27 19:10 ` Ed Swierk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1bf1cf0609271210o5958e39y94e033b478e979f5@mail.gmail.com \
--to=eswierk@arastra.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®