From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C08B2C433FE for ; Fri, 7 Oct 2022 20:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229637AbiJGUtE (ORCPT ); Fri, 7 Oct 2022 16:49:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbiJGUtA (ORCPT ); Fri, 7 Oct 2022 16:49:00 -0400 X-Greylist: delayed 1129 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 07 Oct 2022 13:48:58 PDT Received: from smtpout2.mo529.mail-out.ovh.net (smtpout2.mo529.mail-out.ovh.net [79.137.123.220]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A654813FBE for ; Fri, 7 Oct 2022 13:48:58 -0700 (PDT) Received: from mxplan5.mail.ovh.net (unknown [10.108.1.125]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 94A661303F460; Fri, 7 Oct 2022 22:30:05 +0200 (CEST) Received: from kaod.org (37.59.142.106) by DAG4EX2.mxp5.local (172.16.2.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Fri, 7 Oct 2022 22:30:04 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-106R006ae27c1e1-0ba7-49ef-b5c0-50886aca72bf, 72EF84A86A0CAB1F8CEB0FBBC9371DA6A893A50B) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.66.77.115 Message-ID: Date: Fri, 7 Oct 2022 22:29:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [v2] spi: aspeed: Fix typo in mode_bits field for AST2600 platform Content-Language: en-US To: Chin-Ting Kuo , , , , , , , , , References: <20221005083209.222272-1-chin-ting_kuo@aspeedtech.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20221005083209.222272-1-chin-ting_kuo@aspeedtech.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.106] X-ClientProxiedBy: DAG2EX1.mxp5.local (172.16.2.11) To DAG4EX2.mxp5.local (172.16.2.32) X-Ovh-Tracer-GUID: 61269dbd-0814-42ac-865a-8955e68af19d X-Ovh-Tracer-Id: 10109736741803953074 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeijedgudehtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhepkfffgggfuffvfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepieegvdffkeegfeetuddttddtveduiefhgeduffekiedtkeekteekhfffleevleelnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrddutdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhnsggprhgtphhtthhopedupdhrtghpthhtohepshhtvghvvghnpghlvggvsegrshhpvggvughtvggthhdrtghomhdpoffvtefjohhsthepmhhohedvle Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/5/22 10:32, Chin-Ting Kuo wrote: > Both quad SPI TX and RX modes can be supported on AST2600. > Correct typo in mode_bits field in both ast2600_fmc_data > and ast2600_spi_data structs. > > Signed-off-by: Chin-Ting Kuo Reviewed-by: Cédric Le Goater Thanks, C. > --- > drivers/spi/spi-aspeed-smc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c > index a334e89add86..33cefcf18392 100644 > --- a/drivers/spi/spi-aspeed-smc.c > +++ b/drivers/spi/spi-aspeed-smc.c > @@ -1163,7 +1163,7 @@ static const struct aspeed_spi_data ast2500_spi_data = { > static const struct aspeed_spi_data ast2600_fmc_data = { > .max_cs = 3, > .hastype = false, > - .mode_bits = SPI_RX_QUAD | SPI_RX_QUAD, > + .mode_bits = SPI_RX_QUAD | SPI_TX_QUAD, > .we0 = 16, > .ctl0 = CE0_CTRL_REG, > .timing = CE0_TIMING_COMPENSATION_REG, > @@ -1178,7 +1178,7 @@ static const struct aspeed_spi_data ast2600_fmc_data = { > static const struct aspeed_spi_data ast2600_spi_data = { > .max_cs = 2, > .hastype = false, > - .mode_bits = SPI_RX_QUAD | SPI_RX_QUAD, > + .mode_bits = SPI_RX_QUAD | SPI_TX_QUAD, > .we0 = 16, > .ctl0 = CE0_CTRL_REG, > .timing = CE0_TIMING_COMPENSATION_REG,