From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4811AC4363A for ; Mon, 5 Oct 2020 21:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AE712078E for ; Mon, 5 Oct 2020 21:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729596AbgJEVJs (ORCPT ); Mon, 5 Oct 2020 17:09:48 -0400 Received: from smtprelay0178.hostedemail.com ([216.40.44.178]:56042 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725861AbgJEVJs (ORCPT ); Mon, 5 Oct 2020 17:09:48 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id BC787182CED5B; Mon, 5 Oct 2020 21:09:47 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: fold37_3305bb7271c1 X-Filterd-Recvd-Size: 3213 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Mon, 5 Oct 2020 21:09:46 +0000 (UTC) Message-ID: Subject: Re: [PATCH v3] checkpatch: add new warnings to author signoff checks. From: Joe Perches To: Dwaipayan Ray Cc: linux-kernel-mentees@lists.linuxfoundation.org, Lukas Bulwahn , linux-kernel Date: Mon, 05 Oct 2020 14:09:45 -0700 In-Reply-To: References: <20201005192409.192317-1-dwaipayanray1@gmail.com> <1d8396cb33b33c3d0107ba701b7e597041dfdbc2.camel@perches.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-10-06 at 01:37 +0530, Dwaipayan Ray wrote: > On Tue, Oct 6, 2020 at 1:07 AM Joe Perches wrote: > > On Tue, 2020-10-06 at 00:54 +0530, Dwaipayan Ray wrote: > > > The author signed-off-by checks are currently very vague. > > > Cases like same name or same address are not handled separately. > > > > When you run tests for this, how many mismatches are > > caused by name formatting changes like: > > > > From: "Developer, J. Random" > > ... > > Signed-off-by: "J. Random Developer" ? > > > > Should these differences generate a warning? > > > > Hi, > I ran my tests on non merge commits between v5.7 and v5.8. > > There were a total of 250 NO_AUTHOR_SIGN_OFF Warnings > > 203 of these were email address mismatches. > 32 of these were name mismatches. > > So for the name mismatches, the typical cases are like: > > 'From: tannerlove ' != 'Signed-off-by: Tanner > Love ' > 'From: "朱灿灿" ' != 'Signed-off-by: zhucancan > ' > 'From: Yuval Basson ' != 'Signed-off-by: Yuval > Bason ' > 'From: allen ' != 'Signed-off-by: Allen Chen > ' > > I didn't find the exact formatting change you mentioned in my commit range. > But I did find something like: > > 'From: "Paul A. Clarke" ' != 'Signed-off-by: Paul > Clarke ' > > So it's like some have parts of their names removed, some have language > conflicts, and yet some have well different spellings, or initials, > etc. It's like > a wide variety of things happening here. > > I think considering these, it should be warned about, and let people know > that there might be something wrong going on. > > What do you think? Except for comments and quotes like: From: J. Random Developer (BigCorp) Signed-off-by: "J. Random Developer" I think any time there's a mismatch, there should be a warning emitted. That includes any subaddress detail difference.