From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block <linux-block@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
broonie@kernel.org, linus.walleij@linaro.org,
bfq-iosched@googlegroups.com, oleksandr@natalenko.name
Subject: Re: [PATCH IMPROVEMENT] block, bfq: limit sectors served with interactive weight raising
Date: Fri, 12 Jan 2018 11:15:11 +0100 [thread overview]
Message-ID: <c1cb979a-007c-7607-0c02-4f9110f90a13@applied-asynchrony.com> (raw)
In-Reply-To: <12660CC7-AD89-434A-9BEA-BA0B4C362807@linaro.org>
On 01/12/18 06:58, Paolo Valente wrote:
>
>
>> Il giorno 28 dic 2017, alle ore 15:00, Holger Hoffstätte <holger@applied-asynchrony.com> ha scritto:
>>
>>
>> On 12/28/17 12:19, Paolo Valente wrote:
>> (snip half a tech report ;)
>>
>> So either this or the previous patch ("limit tags for writes and async I/O"
>> can lead to a hard, unrecoverable hang with heavy writes. Since I couldn't
>> log into the affected system anymore I couldn't get any stack traces, blk-mq
>> debug output etc. but there was nothing in dmesg/on the console, so it
>> wasn't a BUG/OOPS.
>>
>> -h
>
> Hi Holger,
> if, as I guess, this problem hasn't gone away for you, I have two
> requests:
> 1) could you share your exact test
> 2) if nothing happens in my systems with your test, would you be
> willing to retry with the dev version of bfq? It should be able to
> tell us what takes to your hang. If you are willing to do this test,
> I'll prepare a branch with everything already configured for you.
Hi,
thanks for following up but there's no need for any of that; it turned out
to be something else since I got the same hang without those patches at
least once (during a btrfs balance, even though it didn't look like btrfs'
fault directly; more like block/mm/helpers.
So on January 7 I posted to linux-block et.al. where I said
"So this turned out to be something else, sorry for the false alarm."
but apparently that didn't make it through since it's not in the
archives either. Sorry.
Long story short, the good news is that I've been running with both patches
since then without any issue. :)
cheers
Holger
next prev parent reply other threads:[~2018-01-12 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 11:19 Paolo Valente
2017-12-28 14:00 ` Holger Hoffstätte
2018-01-07 18:09 ` Holger Hoffstätte
2018-01-12 5:58 ` Paolo Valente
2018-01-12 10:15 ` Holger Hoffstätte [this message]
2018-01-12 10:20 ` Paolo Valente
2018-01-12 15:13 ` Jens Axboe
2017-12-29 14:10 ` Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1cb979a-007c-7607-0c02-4f9110f90a13@applied-asynchrony.com \
--to=holger@applied-asynchrony.com \
--cc=axboe@kernel.dk \
--cc=bfq-iosched@googlegroups.com \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=paolo.valente@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®