From: Jason Yan <yanaijie@huawei.com>
To: John Garry <john.g.garry@oracle.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <dgilbert@interlog.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: scsi_debug: Delete unreachable code in inquiry_vpd_b0()
Date: Wed, 14 Dec 2022 09:18:16 +0800 [thread overview]
Message-ID: <c1ce375c-0c40-0636-e448-b324467816ef@huawei.com> (raw)
In-Reply-To: <20221213142122.1011886-1-john.g.garry@oracle.com>
On 2022/12/13 22:21, John Garry wrote:
> The 2nd return statement in inquiry_vpd_b0() is unreachable, so delete it.
>
> Signed-off-by: John Garry <john.g.garry@oracle.com>
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index b8a76b89f85a..6f637501539c 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -1511,8 +1511,6 @@ static int inquiry_vpd_b0(unsigned char *arr)
> put_unaligned_be64(sdebug_write_same_length, &arr[32]);
>
> return 0x3c; /* Mandatory page length for Logical Block Provisioning */
> -
> - return sizeof(vpdb0_data);
> }
>
> /* Block device characteristics VPD page (SBC-3) */
>
Looks good,
Reviewed-by: Jason Yan <yanaijie@huawei.com>
next prev parent reply other threads:[~2022-12-14 1:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 14:21 John Garry
2022-12-14 1:18 ` Jason Yan [this message]
2022-12-14 3:09 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1ce375c-0c40-0636-e448-b324467816ef@huawei.com \
--to=yanaijie@huawei.com \
--cc=dgilbert@interlog.com \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®