mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: suijingfeng <suijingfeng@loongson.cn>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	loongson-kernel@lists.loongnix.cn, linux-pci@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent
Date: Sat, 19 Aug 2023 10:16:56 +0800	[thread overview]
Message-ID: <c1d090fb-b686-cd64-0452-551e27b74ec8@loongson.cn> (raw)
In-Reply-To: <20230817220853.GA328159@bhelgaas>

Hi,


On 2023/8/18 06:08, Bjorn Helgaas wrote:
>> Please note that before apply this patch, vgaarb can not select the
>> right boot vga due to weird logic introduced with the commit
>> 57fc7323a8e7c ("LoongArch: Add PCI controller support")
> If we need this reference to 57fc7323a8e7c, we need more specifics
> about what the "weird logic" is.  pci_fixup_vgadev() is the only
> obvious VGA connection, so I suppose it's related to that.
>

Sorry, re-reading your reviews,
I realized that I may miss the point,  here, the sentence is not well phased,
Correct expression should be:


Please note that before apply this patch, there don't have a reasonable, system level solution on loongarch.
VGAARB select a wrong device as primary GPU due to the pci_fixup_vgadev() function
introduced with the commit 57fc7323a8e7c ("LoongArch: Add PCI controller support").


  parent reply	other threads:[~2023-08-19  2:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 22:05 Sui Jingfeng
2023-08-17 22:08 ` Bjorn Helgaas
2023-08-18  1:48   ` suijingfeng
2023-08-21 17:33     ` Bjorn Helgaas
2023-08-22  1:19       ` suijingfeng
2023-08-18  4:09   ` suijingfeng
2023-08-21 17:38     ` Bjorn Helgaas
2023-08-22  2:37       ` suijingfeng
2023-08-18  9:31   ` suijingfeng
2023-08-18 10:20   ` suijingfeng
2023-08-21  6:47     ` suijingfeng
2023-08-19  2:16   ` suijingfeng [this message]
2023-08-19  2:18   ` suijingfeng
2023-08-19  2:40   ` suijingfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1d090fb-b686-cd64-0452-551e27b74ec8@loongson.cn \
    --to=suijingfeng@loongson.cn \
    --cc=bhelgaas@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=loongson-kernel@lists.loongnix.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®