From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00F62402453 for ; Tue, 24 Mar 2026 17:29:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774373361; cv=none; b=hsK6/yPwV3jJUNjOGT12sMwOAbMFgpLARswlNTLQx8dzzfKmlLV4Wub3LHXPDaE5cDki8hWHsyf8TiLNmTziWQU9o5iGwdzRBMCOfhcG4ZV+s5CNUX4PpWdZaJiv7P48aApG0E7eALfxz2wQVw/gXGiyei7UQt2xWT6DrhX9nCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774373361; c=relaxed/simple; bh=+ZEbCLyLoc1U+1Me6J7mvrYpkghwfgGTcKlIxBiMGjA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d4efbUh6xyAyndu9TuoZ0mmOAXvWv4yZnAfykJjzmaDtGLftjHH/LyQGdLNsAuFNhxSjwhH9X5VVXftrDU0fSnZLAcA0g29S2xTCpjMJeeeUAwHjl/7s74xIZ6MBrYn75X3+hIHLVDc7SgFhb22XowGYuikk0MBl+FOFwebBaAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=gig/XURb; arc=none smtp.client-ip=209.85.161.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="gig/XURb" Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-67c281e3fa1so780543eaf.0 for ; Tue, 24 Mar 2026 10:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1774373359; x=1774978159; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zhy7rQIQOTUlhyX3h0JAVHxGs6BVrDyegAUb4sJpE/k=; b=gig/XURbyRAsg/bb8Zyf7Wtsozf4/11Hsf/+ggaOK+YgLbT67Cgf0Db1awJU/+Nosa NFnyeuDEzCyqBlTO9kq/2Zm0h/XIAzB3jmS7VmtmE9iYRYTBA1B2aCSJ8YBxW60FTHUk YvpRfuoRQ4pWbOrOIl26SNA+BjfJXqTbcVSPoyU+CgbCPo9w7VTGlz1BMsYjek0wQebr GYt5OO8fjV+1aUksClRqTPZ11kqtuBlFkjQVtsjLVoDZw2hNI0TTqyGBwn/HuI0mqZbs LjnoL7LyXLJGuJT9IWUvd0PWDLSmaDrhQPmSt7boBFzZb3XFrnmvehylwKOeV9r1axAP pWBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774373359; x=1774978159; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zhy7rQIQOTUlhyX3h0JAVHxGs6BVrDyegAUb4sJpE/k=; b=PZkoNDfQ+rbSwQENvgCcE8FthPxgfAM2XENv6oHsXq8Jz0V/to4JNfHbbSWemBqe+G JGFhGdlaeAO+zpqm4xyEIYHN6KXDngZh+au/ZRHvcm4/aIpEGQO7Nh0G8iySKLe5d7GP gZwAJQoYB6E/eOtFDiJIgvNJ29WD4dBjHHakaukia+6jd8WCQeZDuHFZ5skbSdqV/YWn 5LTKevC+1vtLme2SMpwvHoQHKFzcBXJQ0h9Ws5n+1Po/1s4KFnqk06M0OXZQH8mVJJH7 266KJhk2fzSuXSrFy7Iz7J8UCDPOFlMfzPnDcFfaBzDsK6KMkTx8hE6q7uAaIayZYAVB 7p0g== X-Forwarded-Encrypted: i=1; AJvYcCX+BPgq28zG93E2hexLfyP616wveB/Nbj3o9ynSI/RAiWGwbDoO6XEXWWGYKwj2NrhfM4v/+1grUbbscHw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp99UjlcF318wTOoU6CSIGH9k/BS1aXvlEckpFvzlbtVnLl4WK r1HDqX5urSM9BfgfWu04E7ZJND/1sdL6np65Ut/WmzS+g5AginYH9dMI1ThG7twKAks= X-Gm-Gg: ATEYQzy/UFp3sBht7WjBQZ9Ae6Kehjufaaj/R+rgs7p3qVSHO4VIjguJ7n5yipRJRcn V0D95c/Q919pZYV4ziCkrPV11HSWfgask1disQVg1WJWxyl/zgRoZ7HZOV55XOj1IKSDQX4Pfoh hxj2BCo3NpFizARF0raWA2xSF3PAwRWlK1yG5n9DrDeUlNKWfd3qI+ONPKItbkP44j7tZpFornx nBgUpulKo0PRgmDWUO33x1gmpE2uwnlOVAbG2UufER4hOZ3H37G4eqrNXRE/1v8q3YkTP1V+r0/ 83ImhpKAIe9pSJevut9K5qz8w9DUG2rnYhEiUVe/Ii95Z5TsyDpJmAyVedCOWPKobp4Y3zYW5Wk 7NrXSATQf8lCnOHsz+q6bT2xOudb40EZzOQZzmLiopZ8JzRi3wK3ZWnB5Y7NbcE+VvufI1e4f+2 vceKWbJvmgQpwx32PVgSyZ651K4eFSCaMp5hykRJChZOTTaOQ8zttzHuAwQI0rvCelKvCs8wE= X-Received: by 2002:a05:6820:985:b0:67b:bc25:2670 with SMTP id 006d021491bc7-67dff42078dmr407150eaf.26.1774373358893; Tue, 24 Mar 2026 10:29:18 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:8a85:a776:3f75:a1d? ([2600:8803:e7e4:500:8a85:a776:3f75:a1d]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-41c148a5f99sm14342917fac.2.2026.03.24.10.29.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 10:29:18 -0700 (PDT) Message-ID: Date: Tue, 24 Mar 2026 12:29:17 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] iio: proximity: add driver for ST VL53L1X ToF sensor To: Sirat , Jonathan Cameron Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org References: <20260319190738.151614-1-email@sirat.me> <20260319190738.151614-3-email@sirat.me> <8502eb51-53c9-4f1b-92d0-21b06fa4802e@baylibre.com> <20260322110319.7d7558f3@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/24/26 10:17 AM, Sirat wrote: > On Sun, Mar 22, 2026 at 7:52 PM Sirat wrote: >> >> On Sun, Mar 22, 2026 at 5:03 PM Jonathan Cameron wrote: >>> >>> On Sat, 21 Mar 2026 19:37:58 -0500 >>> David Lechner wrote: >>> >>>> On 3/21/26 5:39 PM, Sirat wrote: >>>>> On Sat, Mar 21, 2026 at 11:09 PM David Lechner wrote: >>>>>> >>>>>> On 3/19/26 2:07 PM, Siratul Islam wrote: >> ... >>>> >>>> If you do a buffered read, which stop ranging when it is done, >>>> then how can the direct read work after that? >>>> >>>> Can we just start and stop ranging momentarily for a direct >>>> read? >>> If the latency is high, then worth considering whether autosuspend >>> and runtime pm can help. That way a burst of reads will see low >>> latency after the first one but we won't be wasting power when >>> no one cares. >>> >>> J >>>> >>>> Otherwise, is seems like we would want to have ranging always >>>> enabled. >>>> >> Maybe we should go with continuous ranging then since it's the >> vendor-intended behaviour. >> Since there is no hardware single-shot mode, by design, I think the >> driver should just behave >> as the hardware intended. >>>> >>> > Just for the record, I'm dropping postenable, and keeping predisable > for only the cleanup. > > Thanks, > Sirat predisable must clean up anything done in postenable. So it doesn't make sense to have predisable without a postenable. If there is something unusual going on here, it will need comments with a clear explanation of why it still works when it is breaking the convention.