From: Sekhar Nori <nsekhar@ti.com>
To: Nishanth Menon <nm@ti.com>, Faiz Abbas <faiz_abbas@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <mark.rutland@arm.com>,
<robh+dt@kernel.org>, <t-kristo@ti.com>, <kishon@ti.com>,
<ulf.hansson@linaro.org>, <adrian.hunter@intel.com>,
<michal.simek@xilinx.com>, Tony Lindgren <tony@atomide.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC/SD support
Date: Mon, 10 Dec 2018 13:33:56 +0530 [thread overview]
Message-ID: <c1dd9783-84dc-9dad-ea94-9a14a4ad814d@ti.com> (raw)
In-Reply-To: <20181208155427.jmidz4vsw4k4qj36@akan>
On 08/12/18 9:24 PM, Nishanth Menon wrote:
> On 14:12-20181207, Faiz Abbas wrote:
>
>> +
>> +&sdhci0 {
>> + status = "okay";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&main_mmc0_pins_default>;
>> + bus-width = <8>;
>> + non-removable;
>> + ti,driver-strength-ohm = <50>;
>
> ^^
>
>> +};
>> +
>> +&sdhci1 {
>> + status = "okay";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&main_mmc1_pins_default>;
>> + ti,driver-strength-ohm = <50>;
>
> NAK.
>
> $ git checkout next-20181207
> $ git grep ti,driver-strength-ohm Documentation
> $
>
> Nada.. And.. I think "new phy binding" probably introduces this.
> [1] https://patchwork.kernel.org/project/linux-mmc/list/?series=53185
>
> If your patches are'nt really ready, please send them as RFC, I am not
> really in a mood to track the status of every single driver subsystem.
>
> If your binding is not in linux next at the baremin, as far as I am
> concerned, this is not ready, and should be RFC.
No, RFC does not say "do not merge" or "this has dependencies". RFC is
used to invite a stronger review when introducing a new concept. Its
fair game to apply patches marked RFC if maintainer is okay with the
content.
Dependencies are either noted in cover-letter or below the patch
tear-line. With what you are asking, looks like patches need to be
resubmitted once dependencies are cleared, even if there is no change in
the content itself. This will be additional work.
That said, if it makes life convenient for you, you can impose such a
rule for patches you need to handle. But I think it will take some
getting used for developers who send patches to you as I don't think
this is a norm elsewhere.
Adding Tony and Arnd as well, in case I have missed some recently
accepted convention.
Thanks,
Sekhar
next prev parent reply other threads:[~2018-12-10 8:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 8:42 [PATCH 0/2] Add DT Support for MMCSD in Am65x-evm Faiz Abbas
2018-12-07 8:42 ` [PATCH 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD Faiz Abbas
2018-12-08 5:26 ` Vignesh R
2018-12-08 15:45 ` Nishanth Menon
2018-12-10 13:30 ` Faiz Abbas
2018-12-07 8:42 ` [PATCH 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC/SD support Faiz Abbas
2018-12-08 15:54 ` Nishanth Menon
2018-12-10 8:03 ` Sekhar Nori [this message]
2018-12-10 12:06 ` Nishanth Menon
2018-12-10 12:40 ` Sekhar Nori
2018-12-10 13:33 ` Faiz Abbas
2018-12-10 13:52 ` Nishanth Menon
2018-12-10 13:49 ` Nishanth Menon
2018-12-10 23:47 ` Tony Lindgren
2018-12-11 13:32 ` Sekhar Nori
2018-12-11 5:58 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1dd9783-84dc-9dad-ea94-9a14a4ad814d@ti.com \
--to=nsekhar@ti.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®