From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751259AbdBWMGh (ORCPT ); Thu, 23 Feb 2017 07:06:37 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:2838 "EHLO dggrg01-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751049AbdBWMGf (ORCPT ); Thu, 23 Feb 2017 07:06:35 -0500 Subject: Re: [PATCH 2/2] f2fs: fix the case when there is no free segment to allocate for CURSEG_WARM_NODE To: Jaegeuk Kim , Yunlong Song References: <1487335987-32601-1-git-send-email-yunlong.song@huawei.com> <1487335987-32601-3-git-send-email-yunlong.song@huawei.com> <20170217183933.GB2951@jaegeuk.local> CC: , , , , , , , , From: Chao Yu Message-ID: Date: Thu, 23 Feb 2017 20:06:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170217183933.GB2951@jaegeuk.local> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.58AED046.03D9,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: fa8d62a611bc823d5d19819cd4a2c0f6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/2/18 2:39, Jaegeuk Kim wrote: > Hi Yunlong, > > I already started to test this since a couple of days ago. :) > > http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=908b5f463c82eaf972b149a26bb310f5e25064fd Hi, Jaegeuk, Could you send this patch into mailing list? Anyway I will comment in this patch first. :) > > Thanks, > > On 02/17, Yunlong Song wrote: >> If the free segments are used up, then new_curseg will fail for >> CURSEG_WARM_NODE, in this case, we should use change_curseg instead of >> new_curseg. >> >> Signed-off-by: Yunlong Song >> --- >> fs/f2fs/segment.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >> index df2ff5c..32820cd 100644 >> --- a/fs/f2fs/segment.c >> +++ b/fs/f2fs/segment.c >> @@ -1564,8 +1564,6 @@ static void allocate_segment_by_default(struct f2fs_sb_info *sbi, >> >> if (force) >> new_curseg(sbi, type, true); >> - else if (type == CURSEG_WARM_NODE) Would it be better to check CP_CRC_RECOVERY_FLAG for compatibility of old image? else if (!is_set_ckpt_flags(CP_CRC_RECOVERY_FLAG) && type == CURSEG_WARM_NODE) new_curseg(sbi, type, false); Thanks, >> - new_curseg(sbi, type, false); >> else if (curseg->alloc_type == LFS && is_next_segment_free(sbi, type)) >> new_curseg(sbi, type, false); >> else if (need_SSR(sbi) && get_ssr_segment(sbi, type)) >> -- >> 1.8.5.2 > > . >