mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>,
	kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, jmattson@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] KVM: nVMX: Emulate EPTP switching for the L1 hypervisor
Date: Thu, 3 Aug 2017 14:47:02 +0200	[thread overview]
Message-ID: <c1e59f97-9a31-6213-035b-e723ba26ca78@redhat.com> (raw)
In-Reply-To: <179e5832-0dca-0b5f-b303-d5de18353f5e@redhat.com>


>> Minor nit: Can't you directly do
>>
>> kunmap(page);
>> nested_release_page_clean(page);
>>
>> at this point?
>>
>> We can fix this up later.
> 
> You actually can do simply kvm_vcpu_read_guest_page(vcpu,
> vmcs12->eptp_list_address >> PAGE_SHIFT, &address, index * 8, 8).
> 

Fascinating how nested is able to confuse me every time :) . Sure, this
is just a G1 address, not a G2 address ... (maybe we should rename
nested_get_page to guest_get_page ...)

> Paolo
> 



-- 

Thanks,

David

  reply	other threads:[~2017-08-03 12:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 23:24 [PATCH v6 0/3] Expose VMFUNC to the nested hypervisor Bandan Das
2017-08-01 23:24 ` [PATCH v6 1/3] KVM: vmx: Enable VMFUNCs Bandan Das
2017-08-01 23:24 ` [PATCH v6 2/3] KVM: nVMX: Enable VMFUNC for the L1 hypervisor Bandan Das
2017-08-01 23:24 ` [PATCH 3/3] KVM: nVMX: Emulate EPTP switching " Bandan Das
2017-08-03 11:39   ` David Hildenbrand
2017-08-03 12:41     ` Paolo Bonzini
2017-08-03 12:47       ` David Hildenbrand [this message]
2017-08-03 19:55       ` Bandan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1e59f97-9a31-6213-035b-e723ba26ca78@redhat.com \
    --to=david@redhat.com \
    --cc=bsd@redhat.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome