From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1781C1E25E8 for ; Wed, 21 May 2025 14:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747838970; cv=none; b=Wv8y9Waa1LYlCu8qE3QC3kEQBsc48BKNY5uW7IWfBlNlOllhPq52zOVvSIu2bdmwIVpIUqC8akY6MPlp6YX2oyiBunQWlJB+QVp5uVbMvwVU5zum+vLUKh8WVf5EToLH3Y/M6Sh/9EGHuiMnYII1j8OUuilxMfUYBCwt21j4KP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747838970; c=relaxed/simple; bh=9LDK/QKPWZKQXdNon4+5Vf1nRHt0rEU96RIWKx4oniI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PfhZeaZ+eUHPqkEb+8rGJNb0w0yn9OwTG3xO/laJvKF8Tt9BoaQRUazmXV1CSW2WlkvrQUDlcnbw+XdCoTCy7TjXyd0KMou5UqP5MDICF/DLqRYNGVntm3YA5bpbG3OgIIpR/7uu5pWQopL5iLe3g/KvZ3qOPIX+y9U6HLYTLYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Km/MRYd+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Km/MRYd+" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54L9XM8V000862 for ; Wed, 21 May 2025 14:49:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wzz8YAG+jzGwPnznc9rRApuGlOIZqX/coqLODea7HoY=; b=Km/MRYd+hcUDDrDD y2JpRVEC8uUzuLODglF5ZCmkBbVr0EFGud/9aCGtCxGjUPQsyXiD0gNLyl6UskEe Up++paC6g0Ah7kj7zDJX8mPwBb/W5DVPWMWk+p4RSdADVkdW8Lb3nQaNiUqiNVqy xD8Bn1RqvaWeXLg0K1yNheHjuA4IKODc1V4T3ZD8GvhAj4CpA4BVCrmnsn4gBRci nDyEC1IWHCU/NU8+Dn7UvntEpM3RUAeKIYZsBw4+VJqqUdZ9wA0yo+p0E5B+3tsd 5l2WIy/F1ZqjiAvUnhoho8ReIbcrPCuB51zsJibIQnLExs3oGsVykdg01zFiLQgJ 1b90GA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46rwf6u9p0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 21 May 2025 14:49:27 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6f8df8d4585so54464366d6.3 for ; Wed, 21 May 2025 07:49:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747838966; x=1748443766; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wzz8YAG+jzGwPnznc9rRApuGlOIZqX/coqLODea7HoY=; b=SxyGz710JgVmuMH2bydX4qcxj/gAx52go2BjXUURm9jLP/QbZQMscoOjiDjUpjip95 U0hsy95RxBSwxmHZxpKlNQIuhcynYCDc+NICDVYN2y1+S866luUSpU8uKIg0i9Zaf84F i3mthMxsQvztHfnik4DhJOx201mQUvJX7nD1h5f67+YZDsVDAZIViZKx4ndZx2exYsdf Tp2Q7zY+HZZc1venQ+IbO/hZV6sbxAN1zY+2G29kvYwALgU0Co2iyv7b3mbcH17+DT7o JW0D4+NGqi0KEUFsW4MbpzvT+OA/Z7AWT+PlutZ05y2Kx6u2yJm1CIqBFsH+UZD8gyAq 11Bg== X-Forwarded-Encrypted: i=1; AJvYcCU6whr+Q3QwRB4QcOBIrbzFW1bSEMWEQl0a88XF3TLSEsR10hm0krVlBioGAfgDR+8CSEaToS0amK0nrzc=@vger.kernel.org X-Gm-Message-State: AOJu0YzoMKFAo3PJ4hDwazvU9HO0kteiYu8q0BfkUHc3muWIP/3LheD5 PORoPpNOFeNheOZwgqix4L8dJs5AEvvPiFLHZwNdt5DRDBUNkSzUnlsCzF8ctSMYuteuoASKoKW osjyeLZlbuYWOQ0AtKDs0r5/gn8zDIMLc0KZbS+FLMt3sA93ovKQo1fA8ew450IZn8dTtpZowXD g= X-Gm-Gg: ASbGncs4s6ppkKtVxQX32iFvhzglkXBfS1IEZty3GWkEPY9ElQaxfqRaXpTzimrgqRY AHxyDVYn8subfON7sjj/oTECDijrE2tDvXACWpOKzjvSYcEtxOESCjsg2V7zQMyUInIthuP/D87 2HznP+d39ueE+AJ9Uch3PaZoaVc5P5aTd5+tvz/Q84kCX/CYbvAHLGGTuXRcoRpIsDbS7Es0P1f tGoDMw1WrTs8WyOcQvi+J0lCPfLnd2nIpIRUWcA9jLlfxsGoW+LBPTaMhp+BopZc1H/lGXweU1G kh1XRbdvndfgf+nTwrh7qubTjVtfsPRGPISfbfLTZFI26rANrCEKrktIviU4GXhNtGe5L6Ao+xu 1aYaNe+g2pJiec3zJXCG+lFcnVrMXOJv+cbr72ELVN1zRYhGHJDZaIA/kf4YFtWxv X-Received: by 2002:a05:6214:f05:b0:6e8:ed7f:1a79 with SMTP id 6a1803df08f44-6f8b08d8672mr389817926d6.32.1747838965628; Wed, 21 May 2025 07:49:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGADVYs6P1p5D3eHx76IOayTjYi+ijzrqjc/PCEns20DtYTMFID31WEtYs4tZlh7+gviqZqpg== X-Received: by 2002:a05:6214:f05:b0:6e8:ed7f:1a79 with SMTP id 6a1803df08f44-6f8b08d8672mr389816406d6.32.1747838963560; Wed, 21 May 2025 07:49:23 -0700 (PDT) Received: from ?IPV6:2001:14bb:c7:69ba:b852:d3f4:8957:5a1e? (2001-14bb-c7-69ba-b852-d3f4-8957-5a1e.rev.dnainternet.fi. [2001:14bb:c7:69ba:b852:d3f4:8957:5a1e]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-328084b30easm28014581fa.6.2025.05.21.07.49.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 May 2025 07:49:22 -0700 (PDT) Message-ID: Date: Wed, 21 May 2025 17:49:21 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1] mmc: sdhci-msm: Enable MMC_CAP_AGGRESSIVE_PM for qualcomm controllers To: Sarthak Garg Cc: Adrian Hunter , Ulf Hansson , linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, quic_nguyenb@quicinc.com, quic_rampraka@quicinc.com, quic_pragalla@quicinc.com, quic_sayalil@quicinc.com, quic_nitirawa@quicinc.com, quic_bhaskarv@quicinc.com, kernel@quicinc.com References: <20241104060722.10642-1-quic_sartgarg@quicinc.com> <10c90fee-ce7f-4034-9028-4252f19cb67f@quicinc.com> <064d3eed-c2ea-4b41-85b2-d2a5a922f8c7@quicinc.com> <48c73675-a73f-46f1-81a9-f701a2cf00a5@quicinc.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: <48c73675-a73f-46f1-81a9-f701a2cf00a5@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: BArjquE5frznz3WhqcuPHApJ1ruZmuDk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIxMDE0NSBTYWx0ZWRfX3SVerUKcKFsg B0WazJOU+Wpt26ztnHhPDs37N0DqnQ+HgcWbdxCZr1lg5aiBiyTq3lQgHYG3L+L6FEX5703KJ1D DTnu04AkL5CYt153eRUzvmEv82VUB+3piSwztvHsermgDdtm1zvdF3mweOz8i+S+tyAbcgr4rOs wfdnIhqStfSThQaCZnJ8DOdOrdvkJD8esgpCuU534TJHzQx+ps+2JlHIoGwPOYyDPhZb7qnFk5q /QD5fd9vSDroMDqJ2oTY5jSCt/Zk+KZpxTMfbWvpVXJ90n8gM4hrrSqwjOJpoaDJxC1mwVZcRzN /niCBOQkS9GTlC/GyCiX6BitLAcXNPJ7cBoNThyGko82Kd/4UmaIBsAKOVLTLGcfBhAlcKKAxOW LLMfd2JqLHivpj6yF78wb0rvfo09k2xRR65vpYe2pvkbvIb1cu0+uV2nC5qLESPJxL+19sVn X-Authority-Analysis: v=2.4 cv=fZOty1QF c=1 sm=1 tr=0 ts=682de7f7 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=3-RhneuVAAAA:8 a=JVpan6spTK3LsyV6_coA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=TjNXssC_j7lpFel5tvFf:22 a=VLVLkjT_5ZicWzSuYqSo:22 X-Proofpoint-ORIG-GUID: BArjquE5frznz3WhqcuPHApJ1ruZmuDk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-21_04,2025-05-20_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505210145 On 21/05/2025 17:35, Sarthak Garg wrote: > > > On 5/21/2025 6:25 PM, Dmitry Baryshkov wrote: >> On Wed, May 21, 2025 at 12:46:49PM +0530, Sarthak Garg wrote: >>> >>> >>> On 11/15/2024 6:53 PM, Dmitry Baryshkov wrote: >>>> On Fri, 15 Nov 2024 at 12:23, Sarthak Garg >>>> wrote: >>>>> >>>>> >>>>> >>>>> On 11/4/2024 4:19 PM, Dmitry Baryshkov wrote: >>>>>> On Mon, Nov 04, 2024 at 11:37:22AM +0530, Sarthak Garg wrote: >>>>>>> Enable MMC_CAP_AGGRESSIVE_PM for qualcomm controllers. >>>>>>> This enables runtime PM for eMMC/SD card. >>>>>> >>>>>> Could you please mention, which platforms were tested with this >>>>>> patch? >>>>>> Note, upstream kernel supports a lot of platforms, including >>>>>> MSM8974, I >>>>>> think the oldest one, which uses SDHCI. >>>>>> >>>>> >>>>> This was tested with qdu1000 platform. >>>> >>>> Are you sure that it won't break other platforms? >>>> >>> >>> Thanks for your valuable comment. >>> I am not sure about the older platforms so to avoid issues on older >>> platforms we can enable this for all SDCC version 5.0 targets ? >> >> No, there are still a lot of platforms. Either explain why this is >> required for all v5 platforms (and won't break those) or find some other >> way, e.g. limit the change to QDU1000, explaining why it is _not_ >> applicable to other platforms. >> > > Thanks for your comment. No need to. > I agree with your concern but for me also its not possible to test on > all the platforms. Sure. > Lets say if I want to enable this caps for QDU1000 for which it has been > tested and on any other upcoming target after testing, then how can I > proceed to enable? Let's start from the beginning: why do you want to enable it on QDU1000? > > One option I had thought of was to implement this using compatible > string, then for all the upcoming platforms using this compatible string > as a fallback. > But this doesn't look optimal to use compatible string for just one flag > and also this capability is not platform specific and we will be needing > for all the platforms. Please share your opinion on this. > > Another option that I could have thought of is using device tree based > approach but seems that was not accepted earlier : > https://patchwork.kernel.org/project/linux-mmc/ > patch/20230129023630.830764-1-chenhuiz@axis.com/ > > So it would be helpful if you can suggest some approach? Worst case, just tie it to the SoC-specific compat string that is already a part of the bindings. -- With best wishes Dmitry