From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A51FF426D0E for ; Fri, 6 Mar 2026 19:39:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772825983; cv=none; b=ogQm71y4GGQ72vj2+zbsK2HnMHAjzwLHoNAX5T7UR4LwdOft4bY3m3aId5bDChBSLq9KrGeZjvr/pmCFFp3/rT/k1QRLeY7Dfo8MBprLjU3AIwogXGllxbpe7ZvjbzSR362GyFgB8F9tffoa5k7E/Oq3krKfXSf0houw85z/WtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772825983; c=relaxed/simple; bh=50XqAZ06m9g3UMAiRpPd57k/8mwsrzQ+ypcSKMqsSoU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FleoI4T4acwE7x34bqj3sD5BMIPGmXrfr5CjAS8UQfxM+EnTZ1uqp8KUqKnjK5R5DRpntmjqLKvbExoJmBhM2rj3J54KDarjTFUBO/1Cn55vO2CUH3j5XKR81lkgP8UlDttyz2vYWOzKLPrOpgUYrqckl93clw87lYESQdPjvT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=2QFV/qb9; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="2QFV/qb9" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=OmHM+KnL43Ma2pC7tvmsDtqgnqZz0DSdLjwo0zHMF70=; b=2QFV/qb9Uj3Hm1XPrVhiSRtQ7B JTFiKH3DwrIcnrWSixqDlOgkwl6WnzhlLtyJsoT8aDHAV2jNVz8UOfXQUIOZlKmbIm4ojJHXVmgET X1XIojGGbWgyC1KxT4gZFtG1lkdROnvvOloQl4H4Pwhhm3VI+8C43tLbS5j3tNf276Mqv3rQdeaTM J1ynsvc/tE+LJUNCoMZHSdkvz10AG4e5I+bnw8rPqIYTnXJl171ysBqgEFQ7jjihWvrpWel1uMv9x WXNbbZH7JOzg71q1LX77AA61s1/Tr9It6/tMvdFkZL0hvv56E3DhiJ/32OLi+VmbzcUBtf1ZuRcK9 lnLteYPQ==; Received: from [50.53.43.113] (helo=[192.168.254.34]) by bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyb1P-00000004Pdi-41M8; Fri, 06 Mar 2026 19:39:40 +0000 Message-ID: Date: Fri, 6 Mar 2026 11:39:39 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] iopoll: fix parameter names in kernel-doc To: Jani Nikula , linux-kernel@vger.kernel.org Cc: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org References: <20260306063829.2059375-1-rdunlap@infradead.org> <7b4ab61091b0bd032e129e46237f707d2448ca08@intel.com> Content-Language: en-US From: Randy Dunlap In-Reply-To: <7b4ab61091b0bd032e129e46237f707d2448ca08@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/6/26 2:31 AM, Jani Nikula wrote: > On Thu, 05 Mar 2026, Randy Dunlap wrote: >> Correct the parameter names to avoid kernel-doc warnings: >> >> Warning: include/linux/iopoll.h:169 function parameter 'sleep_us' not >> described in 'read_poll_timeout_atomic' >> Warning: ../include/linux/iopoll.h:169 function parameter >> 'sleep_before_read' not described in 'read_poll_timeout_atomic' > > I think the right fix is to rename the parameters instead. They're > passed on to poll_timeout_us_atomic() where the parameters are called > delay_us and delay_before_op, emphasizing that this is atomic i.e. no > sleep. OK, will do. Thanks. -- ~Randy