From: Alain Cousinie <alain.cousinie@laposte.net>
To: Shang En Sim <sim@shangen.org>
Cc: "Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: hp-wmi: add charge_behaviour support for Spectre 8C17
Date: Tue, 8 Sep 2026 14:19:39 +0200 [thread overview]
Message-ID: <c1fcd1f6-38a9-48a6-9986-9723d2dead39@laposte.net> (raw)
In-Reply-To: <20260812062113.27741-1-sim@shangen.org>
Le 12/08/2026 à 08:20, Shang En Sim a écrit :
> HP Spectre x360 16-aa0xxx (board 8C17) exposes battery charge mode control
> through WMI command 0x2b (GBCO/SBCO). Inhibit charge, force discharge, and
> restoring automatic charging all work through that command.
>
>
> +#if IS_REACHABLE(CONFIG_ACPI_BATTERY)
> +static const struct dmi_system_id hp_wmi_charge_control_quirks[] __initconst = {
> + {
> + /* HP Spectre x360 16-aa0xxx */
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
> + DMI_MATCH(DMI_BOARD_NAME, "8C17"),
> + },
> + },
> + {}
> +};
> +#endif
> +
Hello Shang,
I am using an HP Spectre 14-eu0xxx (board 8C15), which appears to be identical to the 8C17 model regarding `hp-wmi`.
(See also https://github.com/aigilea/hp_spectre_x360_14_eu0xxx, which also covers the 16-aa0xxx model.)
I found the same elements in the DSDT, and my tests seem to work after modifying `hp-wmi.c`.
Is it possible to add 8C15 to your patch?
+ {
+ /* HP Spectre x360 14-eu0xxx */
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
+ DMI_MATCH(DMI_BOARD_NAME, "8C15"),
+ },
+ },
Thanks in advance.
Alain
next prev parent reply other threads:[~2026-09-08 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 6:20 Shang En Sim
2026-09-08 12:19 ` Alain Cousinie [this message]
2026-09-17 11:22 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1fcd1f6-38a9-48a6-9986-9723d2dead39@laposte.net \
--to=alain.cousinie@laposte.net \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sim@shangen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®