mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wangao Wang <wangao.wang@oss.qualcomm.com>
To: Deepa Guthyappa Madivalara <deepa.madivalara@oss.qualcomm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Bryan O'Donoghue <bod@kernel.org>
Cc: wangao.wang@oss.qualcomm.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	kernel test robot <lkp@intel.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: Re: [PATCH v8 3/5] media: iris: Add support for AV1 format in iris decoder
Date: Mon, 8 Dec 2025 18:51:37 +0800	[thread overview]
Message-ID: <c1fde623-9f2b-4904-8008-8dd9a02a352f@oss.qualcomm.com> (raw)
In-Reply-To: <20251202-av1d_stateful_v3-v8-3-2f74a81773b4@oss.qualcomm.com>



On 2025/12/3 7:03, Deepa Guthyappa Madivalara wrote:
> +static struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
>   	{
>   		.cap_id = PROFILE_H264,
>   		.min = V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE,
> @@ -759,6 +778,8 @@ const struct iris_platform_data sm8550_data = {
>   	.dma_mask = 0xe0000000 - 1,
>   	.fwname = "qcom/vpu/vpu30_p4.mbn",
>   	.pas_id = IRIS_PAS_ID,
> +	.inst_iris_fmts = platform_fmts_sm8550_dec,
> +	.inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8550_dec),
>   	.inst_caps = &platform_inst_cap_sm8550,
>   	.inst_fw_caps_dec = inst_fw_cap_sm8550_dec,
>   	.inst_fw_caps_dec_size = ARRAY_SIZE(inst_fw_cap_sm8550_dec),
> @@ -851,6 +872,8 @@ const struct iris_platform_data sm8650_data = {
>   	.dma_mask = 0xe0000000 - 1,
>   	.fwname = "qcom/vpu/vpu33_p4.mbn",
>   	.pas_id = IRIS_PAS_ID,
> +	.inst_iris_fmts = platform_fmts_sm8550_dec,
> +	.inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8550_dec),
>   	.inst_caps = &platform_inst_cap_sm8550,
>   	.inst_fw_caps_dec = inst_fw_cap_sm8550_dec,
>   	.inst_fw_caps_dec_size = ARRAY_SIZE(inst_fw_cap_sm8550_dec),

I noticed that you didn’t add inst_iris_fmts to the platform data for 
qcs8300 and sm8750, which will prevent the decoders on these platforms 
from running.

-- 
Best Regards,
Wangao


  reply	other threads:[~2025-12-08 10:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-02 23:03 [PATCH v8 0/5] Enable support for AV1 stateful decoder Deepa Guthyappa Madivalara
2025-12-02 23:03 ` [PATCH v8 1/5] media: uapi: videodev2: Add " Deepa Guthyappa Madivalara
2025-12-02 23:03 ` [PATCH v8 2/5] media: v4l2: Add description for V4L2_PIX_FMT_AV1 in v4l_fill_fmtdesc() Deepa Guthyappa Madivalara
2025-12-02 23:03 ` [PATCH v8 3/5] media: iris: Add support for AV1 format in iris decoder Deepa Guthyappa Madivalara
2025-12-08 10:51   ` Wangao Wang [this message]
2025-12-10  0:40     ` Deepa Guthyappa Madivalara
2025-12-02 23:03 ` [PATCH v8 4/5] media: iris: Define AV1-specific platform capabilities and properties Deepa Guthyappa Madivalara
2025-12-08 10:54   ` Wangao Wang
2025-12-10  0:41     ` Deepa Guthyappa Madivalara
2025-12-02 23:03 ` [PATCH v8 5/5] media: iris: Add internal buffer calculation for AV1 decoder Deepa Guthyappa Madivalara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1fde623-9f2b-4904-8008-8dd9a02a352f@oss.qualcomm.com \
    --to=wangao.wang@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=bod@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=deepa.madivalara@oss.qualcomm.com \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mchehab@kernel.org \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®