From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938995AbcJGPlZ (ORCPT ); Fri, 7 Oct 2016 11:41:25 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:35367 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938860AbcJGPkv (ORCPT ); Fri, 7 Oct 2016 11:40:51 -0400 Subject: Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning To: Greg Kroah-Hartman References: <120f00f2-94b6-aead-7bb4-9917bc338660@redhat.com> <20161007035649.GA17183@kroah.com> Cc: Rob Herring , Arnd Bergmann , Linux Kernel Mailing List From: Laura Abbott Message-ID: Date: Fri, 7 Oct 2016 08:40:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161007035649.GA17183@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/06/2016 08:56 PM, Greg Kroah-Hartman wrote: > On Thu, Oct 06, 2016 at 04:53:20PM -0700, Laura Abbott wrote: >> On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on >> Fedora rawhide since it sounded harmless enough. It spewed warnings >> and panicked some systems. Clearly it's doing its job >> well of finding drivers that can't handle remove properly and I >> underestimated it. > > Yes, we knew it was going to find bugs, you were brave :) > Sure, let's go with brave. That makes me sound good ;) >> I was expecting to maybe find a driver or two. >> Can we get stronger Kconfig text indicating that this shouldn't be >> turned on lightly? I'll be turning the option off in Fedora but sending >> out reports from what was found. > > Care to send a patch with the wording change you would have found better > to warn yourself not to do this? > Sure. > thanks, > > greg k-h > Thanks, Laura