From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC1661B28D for ; Tue, 26 Mar 2024 17:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711475024; cv=none; b=UHnCIIzAN1SpUMjopi94/35ctX00CLE4lpBWogobbyInu5LDZ3rQ+pdGkQYlJz/jYjoiFiiFhc7isGxs58PRXmkhNBX7IVP5R8m7C21Uq86mKdcKaxXrHXUHTI0ZjCwaBVNr0ZKWpedvId5u6wQ0ZEKzh3JahOWueFs9GAGxo4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711475024; c=relaxed/simple; bh=oUwPm+LhhzEAcP5+F2HK822pq0W7vnOXkTx+lfC3XGs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ONRpGodNSf/YO2adueve6572n7QJAFu4iDXm0Ledr5A8PNsXhTzq1z+ZyZ5aB20hs6CqgIWn8IyktkoV46ac6S270Wg5/o2vZn4ObPJKHXKXUHTlXQzxXaLgiwpxnpB9DnuQqVvuBv7olYbkv8Sj4W5mgBCHAlzjLDFp8zO5OMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Cu8OTgNH; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Cu8OTgNH" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4148cbc5b01so8607705e9.1 for ; Tue, 26 Mar 2024 10:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711475021; x=1712079821; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=d+pLwrN7IzQtt4YVaoVDzL2T1kedcYqHyKuMC9bhaZk=; b=Cu8OTgNH1LeXqtz7/X/onlu7RaIMEl/6qL9su2RKKyfYJvRM54ws+236tmtVA6Db6m +yhImJcWV5NPWxhWdhxNfJ9N4SVLsYhPDn2y1s7luabhNAYhm52mKzPmoa2wVYWwQWS6 HLpJrNLLncSkipIsD2IJxhCLcr9kVlQwdeLg4rf8ArSxq3H0vXJLvyeBwpueChxNmr/F 7q3RmiTxiDJDBTJtCoivT5nWn0/bBS6ALPPWd+4TnQicLRDQOVfNQMfp3EojBrBG9c9m GegCyjxn84pJlHX7e5BbCnu0YU74p4DKOldXdpvZDN1Dyk8h/QyVyf/7qXEAh88JzPqd PlBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711475021; x=1712079821; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=d+pLwrN7IzQtt4YVaoVDzL2T1kedcYqHyKuMC9bhaZk=; b=Z8XZmfY9zEV4MgIaI9ihuRppJ4yCTcWQLV6pIIf1B2dhBgHh0gpaearwqWYuHEM6E+ qseNEC4b2DVq2L8seS04XlbL7Em5DE252QQ3IT5DIevxotQDTaofWx83bGg97jZvBo/7 PjFTBvDwff2kfFtbWnJfzf+REdBcnNs/zv6pmRUoWhZmcagFXXgPRe7ErWim+Lehk3Im KBBT+ift81xBee8GJLNKov2g9P9Lbo+iry3vxm1qXsj5Mr2gfu+4/sEvrbcWkGATxmIx YEa7pPdQpTaWEWsWLjJbVJ6U6lj2+2SvHaJRl3tvKCEf8jdH4/L06cC+DyezeSVOjUZ0 RZLQ== X-Forwarded-Encrypted: i=1; AJvYcCX3rOJHZC2NTZikWzrK0lQj1UkekTxiL9IMVuzdU7o+YvXHVdOXuofR3ctdqJieA/7paEToSZ547ugm+JhBtvLMiOjRvuyWnMWqd8TR X-Gm-Message-State: AOJu0Yz5TzYCWOjlQ0MtinrlAozYD6UXXtg3X0j7sz5bhflVbh2sS5a1 aouQLHEaow2z/c+JnVgS1xDZPOtgYN8Q4yoBEmUayq2DLg2cTk6wDArUCtkmHcE= X-Google-Smtp-Source: AGHT+IEyEXDtYyd75K2bmQfUIiC16cTW8DNiy24ESWAtnb8lrm3Dg6lDC68YQjKZFYHpQF9mZihYjg== X-Received: by 2002:a05:600c:2201:b0:414:71b2:73c4 with SMTP id z1-20020a05600c220100b0041471b273c4mr8862368wml.12.1711475021184; Tue, 26 Mar 2024 10:43:41 -0700 (PDT) Received: from [10.1.1.109] ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id j19-20020a05600c191300b00414610d9223sm12215452wmq.14.2024.03.26.10.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 10:43:40 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 1/3] clk: samsung: introduce nMUX for MUX clks that can reparented From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Tudor Ambarus , peter.griffin@linaro.org, krzysztof.kozlowski@linaro.org Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, willmcvicker@google.com, kernel-team@android.com, s.nawrocki@samsung.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, semen.protsenko@linaro.org, linux-clk@vger.kernel.org, jaewon02.kim@samsung.com Date: Tue, 26 Mar 2024 17:43:39 +0000 In-Reply-To: <20240326172813.801470-2-tudor.ambarus@linaro.org> References: <20240326172813.801470-1-tudor.ambarus@linaro.org> <20240326172813.801470-2-tudor.ambarus@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2-1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Tudor, On Tue, 2024-03-26 at 17:28 +0000, Tudor Ambarus wrote: > All samsung MUX clocks that are defined with MUX() set the > CLK_SET_RATE_NO_REPARENT flag in __MUX(), which prevents MUXes to be > reparented during clk_set_rate(). >=20 > Introduce nMUX() for MUX clocks that can be reparented. What does n in nMUX stand for? > [...] > =C2=A0 > +/* Used by MUX clocks where reparenting is allowed. */ > +#define __nMUX(_id, cname, pnames, o, s, w, f, mf) \ > + { \ > + .id =3D _id, \ > + .name =3D cname, \ > + .parent_names =3D pnames, \ > + .num_parents =3D ARRAY_SIZE(pnames), \ > + .flags =3D f, \ > + .offset =3D o, \ > + .shift =3D s, \ > + .width =3D w, \ > + .mux_flags =3D mf, \ > + } You've duplicated __MUX() and removed the CLK_SET_RATE_NO_REPARENT from flags - I think it would make sense to instead drop the flag from the existing __MUX(), and adjust the only two existing users of the macro, i.e. to add it in MUX() and MUX_F(). Cheers, Andre'