mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Mark Brown" <broonie@kernel.org>, "Arnd Bergmann" <arnd@kernel.org>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
	"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
	"Bard Liao" <yung-chuan.liao@linux.intel.com>,
	"Daniel Baluta" <daniel.baluta@nxp.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.dev>,
	sound-open-firmware@alsa-project.org,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: SOF: Intel: select SND_SOC_SDW_UTILS=y from SND_SOC_SOF_HDA_GENERIC=y
Date: Thu, 11 Jun 2026 20:22:21 +0200	[thread overview]
Message-ID: <c216893d-0548-42ac-8a3b-4be397a79fc7@app.fastmail.com> (raw)
In-Reply-To: <airEQ7ER7jUF3SQ_@sirena.co.uk>

On Thu, Jun 11, 2026, at 16:20, Mark Brown wrote:
> On Thu, Jun 11, 2026 at 03:23:05PM +0200, Arnd Bergmann wrote:
>> +++ b/sound/soc/sof/intel/Kconfig
>> @@ -335,7 +335,7 @@ config SND_SOC_SOF_HDA_GENERIC
>>  	select SND_INTEL_DSP_CONFIG
>>  	select SND_SOC_SOF_HDA_LINK_BASELINE
>>  	select SND_SOC_SOF_HDA_PROBES
>> -	select SND_SOC_SDW_UTILS if SND_SOC_SOF_INTEL_SOUNDWIRE
>> +	select SND_SOC_SDW_UTILS if SND_SOC_SOF_INTEL_SOUNDWIRE !=n
>
> Can we end up with SND_SOC_SDW_UTILS=y but SOUNDWIRE=m?  Though I think
> that's a potential issue anyway...

I don't see that combination in any randconfig builds and haven't
managed to produce it in menuconfig, but I can't swear that it's
impossible either.

I do feel that the entire set of dependencies around
SOUNDWIRE, HDA and the Intel/AMD drivers is too fragile,
so it would be good if someone could manage to simplify this
in some form, but the best I can do at the moment it to
address regressions when they happen.

With the patches that I have sent, plus the "ASoC: amd: acp: Fix
linker error with SDCA quirks" one from Syed Saba Kareem that
I'm testing at the moment, I get no link failures in randconfig
kernels.

      Arnd

  reply	other threads:[~2026-06-11 18:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11 13:23 Arnd Bergmann
2026-06-11 13:23 ` [PATCH 2/2] ASoC: SOF: Intel: hda-sdw-bpt: select SND_SOF_SOF_HDA_SDW_BPT properly Arnd Bergmann
2026-06-11 14:20 ` [PATCH 1/2] ASoC: SOF: Intel: select SND_SOC_SDW_UTILS=y from SND_SOC_SOF_HDA_GENERIC=y Mark Brown
2026-06-11 18:22   ` Arnd Bergmann [this message]
2026-06-11 18:55     ` Mark Brown
2026-06-11 19:18       ` Arnd Bergmann
2026-06-11 19:20         ` Mark Brown
2026-06-11 14:21 ` Julian Braha
2026-06-11 19:40 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c216893d-0548-42ac-8a3b-4be397a79fc7@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=broonie@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=sound-open-firmware@alsa-project.org \
    --cc=tiwai@suse.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®