mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	"Katsuhiro Suzuki" <suzuki.katsuhiro@socionext.com>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH -next] ASoC: simple-card-utils: remove set but not used variable ''
Date: Mon, 25 Mar 2019 11:03:18 +0800	[thread overview]
Message-ID: <c216f899-fdfc-6f99-3f76-5ee64680b2fe@huawei.com> (raw)
In-Reply-To: <87a7hjitm0.wl-kuninori.morimoto.gx@renesas.com>

On 2019/3/25 10:31, Kuninori Morimoto wrote:
> 
> Hi
> 
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
>> sound/soc/generic/simple-card-utils.c:164:18: warning:
>>  parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>>
>> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
>> asoc_simple_debug_info()"), so can be removed.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
> 
> I think dai_name parameter itself is no longer needed for this function,
> but, it will be removed if all driver switched to modern dai_link style.
> So, it is not a big deal.
> 
> 	Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks, yes, this just a code cleanup.

> 
> Best regards
> ---
> Kuninori Morimoto
> 
> .
> 


  parent reply	other threads:[~2019-03-25  3:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-23  2:08 YueHaibing
     [not found] ` <87a7hjitm0.wl-kuninori.morimoto.gx@renesas.com>
2019-03-25  3:03   ` YueHaibing [this message]
2019-03-25  3:17 ` [PATCH v2 -next] ASoC: simple-card-utils: remove set but not used variable 'dai_name' YueHaibing
2019-03-27 14:53   ` Mukesh Ojha
2019-03-25  7:42 ` [PATCH -next] ASoC: simple-card-utils: remove set but not used variable '' Mukesh Ojha
2019-03-25  7:58   ` YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c216f899-fdfc-6f99-3f76-5ee64680b2fe@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=suzuki.katsuhiro@socionext.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®