From: Marek Vasut <marex@denx.de>
To: Richard Zhu <hongxing.zhu@nxp.com>,
vkoul@kernel.org, a.fatoum@pengutronix.de,
p.zabel@pengutronix.de, l.stach@pengutronix.de,
bhelgaas@google.com, lorenzo.pieralisi@arm.com, robh@kernel.org,
shawnguo@kernel.org, alexander.stein@ew.tq-group.com,
richard.leitner@linux.dev
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-imx@nxp.com
Subject: Re: [RESEND v12 4/4] phy: freescale: imx8m-pcie: Add i.MX8MP PCIe PHY support
Date: Sat, 17 Dec 2022 20:46:31 +0100 [thread overview]
Message-ID: <c21996f3-0f1d-8b77-95fb-ab98f3a28913@denx.de> (raw)
In-Reply-To: <1665625622-20551-5-git-send-email-hongxing.zhu@nxp.com>
On 10/13/22 03:47, Richard Zhu wrote:
Hi,
[...]
> @@ -238,6 +251,14 @@ static int imx8_pcie_phy_probe(struct platform_device *pdev)
> return PTR_ERR(imx8_phy->reset);
> }
>
> + if (imx8_phy->drvdata->variant == IMX8MP) {
> + imx8_phy->perst =
> + devm_reset_control_get_exclusive(dev, "perst");
> + if (IS_ERR(imx8_phy->perst))
> + dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
I just notice this , are we missing return here ?
That is ... return dev_err_probe(...) ?
> + "Failed to get PCIE PHY PERST control\n");
> + }
[...]
next prev parent reply other threads:[~2022-12-17 19:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 1:46 [PATCH RESEND v12 0/4] Add the iMX8MP PCIe support Richard Zhu
2022-10-13 1:46 ` [RESEND v12 1/4] dt-binding: phy: Add i.MX8MP PCIe PHY binding Richard Zhu
2022-10-13 1:47 ` [RESEND v12 2/4] phy: freescale: imx8m-pcie: Refine register definitions Richard Zhu
2022-10-13 1:47 ` [RESEND v12 3/4] phy: freescale: imx8m-pcie: Refine i.MX8MM PCIe PHY driver Richard Zhu
2022-10-13 1:47 ` [RESEND v12 4/4] phy: freescale: imx8m-pcie: Add i.MX8MP PCIe PHY support Richard Zhu
2022-12-17 19:46 ` Marek Vasut [this message]
2022-12-19 3:25 ` Hongxing Zhu
2022-12-19 6:03 ` Marek Vasut
2022-10-17 5:31 ` [PATCH RESEND v12 0/4] Add the iMX8MP PCIe support Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c21996f3-0f1d-8b77-95fb-ab98f3a28913@denx.de \
--to=marex@denx.de \
--cc=a.fatoum@pengutronix.de \
--cc=alexander.stein@ew.tq-group.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=richard.leitner@linux.dev \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®