From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758936AbcHaDUM (ORCPT ); Tue, 30 Aug 2016 23:20:12 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:45487 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758823AbcHaDUI (ORCPT ); Tue, 30 Aug 2016 23:20:08 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: xzy.xu@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: xzy.xu@rock-chips.com X-UNIQUE-TAG: <73446d03a06301032383b77019854ab7> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 3/4] arm64: dts: rockchip: add clk_syscon for sdhci on rk3399 To: Shawn Lin , Heiko Stuebner , Rob Herring , Ulf Hansson References: <1472607448-4462-1-git-send-email-shawn.lin@rock-chips.com> <1472607448-4462-4-git-send-email-shawn.lin@rock-chips.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Douglas Anderson , Adrian Hunter , linux-rockchip@lists.infradead.org From: Ziyuan Xu Message-ID: Date: Wed, 31 Aug 2016 11:19:35 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472607448-4462-4-git-send-email-shawn.lin@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, On 2016年08月31日 09:37, Shawn Lin wrote: > We are intent on letting the sdhci variant driver handle this > optional clock on rk3399 platform now. > > Signed-off-by: Shawn Lin > --- Thanks for your patch, we can gate aclk_emmcgrf now as soon as sdhci driver suspend. Reviewed-by: Ziyuan Xu Tested-by: Ziyuan Xu > > Changes in v2: None > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index bc86e8c..d26c6ad 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -233,8 +233,9 @@ > arasan,soc-ctl-syscon = <&grf>; > assigned-clocks = <&cru SCLK_EMMC>; > assigned-clock-rates = <200000000>; > - clocks = <&cru SCLK_EMMC>, <&cru ACLK_EMMC>; > - clock-names = "clk_xin", "clk_ahb"; > + clocks = <&cru SCLK_EMMC>, <&cru ACLK_EMMC>, > + <&cru ACLK_EMMC_GRF>; > + clock-names = "clk_xin", "clk_ahb", "clk_syscon"; > clock-output-names = "emmc_cardclock"; > #clock-cells = <0>; > phys = <&emmc_phy>;