From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C299C77B7E for ; Mon, 29 May 2023 17:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbjE2RNF (ORCPT ); Mon, 29 May 2023 13:13:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbjE2RND (ORCPT ); Mon, 29 May 2023 13:13:03 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9BA6CD for ; Mon, 29 May 2023 10:13:00 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7FB1721A7A; Mon, 29 May 2023 17:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1685380379; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rB9VfmOx0wBbizK583+OAKBFCiJju0fCCUZtBDpksf0=; b=IfKR3S49D1e53xZzyj7oNKSFqsrS8eprPxkhez5rW5ouuGnSo/VbCitNGkF6GsKzXleW85 0NKyzYwwIXM65hgXAtTXTVJVcEenpNiov2PMKWiVeFLejO5kdZhUmjpCY9nhneZLXJyjpV wYROWMDSYRsyeArMPnkJeSU6rrlbDEc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1685380379; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rB9VfmOx0wBbizK583+OAKBFCiJju0fCCUZtBDpksf0=; b=lncwWhG/nHnwgOAJdvIeT2YDKUWV+8YX5uStXPxR0ZvC4EgoUPpw18wO2fe0EMBhArGge6 ntrGfZqhwaW6LNCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 318B11332D; Mon, 29 May 2023 17:12:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wqlqCxvddGQJXwAAMHmgww (envelope-from ); Mon, 29 May 2023 17:12:59 +0000 Message-ID: Date: Mon, 29 May 2023 19:12:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 5/5] mm: compaction: drop redundant watermark check in compaction_zonelist_suitable() Content-Language: en-US To: Johannes Weiner , Andrew Morton Cc: Mel Gorman , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com References: <20230519123959.77335-1-hannes@cmpxchg.org> <20230519123959.77335-6-hannes@cmpxchg.org> From: Vlastimil Babka In-Reply-To: <20230519123959.77335-6-hannes@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/19/23 14:39, Johannes Weiner wrote: > The watermark check in compaction_zonelist_suitable(), called from > should_compact_retry(), is sandwiched between two watermark checks > already: before, there are freelist attempts as part of direct reclaim > and direct compaction; after, there is a last-minute freelist attempt > in __alloc_pages_may_oom(). > > The check in compaction_zonelist_suitable() isn't necessary. Kill it. > > Signed-off-by: Johannes Weiner Acked-by: Vlastimil Babka