From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D514CC3A59B for ; Mon, 2 Sep 2019 07:52:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B39D4214AE for ; Mon, 2 Sep 2019 07:52:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729980AbfIBHwy (ORCPT ); Mon, 2 Sep 2019 03:52:54 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:40030 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729408AbfIBHwy (ORCPT ); Mon, 2 Sep 2019 03:52:54 -0400 Received: from [91.156.6.193] (helo=redipa) by farmhouse.coelho.fi with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92) (envelope-from ) id 1i4h8g-0003aF-Cr; Mon, 02 Sep 2019 10:52:38 +0300 Message-ID: From: Luca Coelho To: Krzysztof Wilczynski , Kalle Valo Cc: Johannes Berg , Emmanuel Grumbach , Intel Linux Wireless , "David S. Miller" , Sara Sharon , Shaul Triebitz , Liad Kaufman , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 02 Sep 2019 10:52:36 +0300 In-Reply-To: <20190831220108.10602-1-kw@linux.com> References: <20190831220108.10602-1-kw@linux.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] iwlwifi: mvm: Move static keyword to the front of declarations Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2019-09-01 at 00:01 +0200, Krzysztof Wilczynski wrote: > Move the static keyword to the front of declarations of > he_if_types_ext_capa_sta and he_iftypes_ext_capa, and > resolve the following compiler warnings that can be seen > when building with warnings enabled (W=1): > > drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:427:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:434:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > Signed-off-by: Krzysztof Wilczynski > --- > Related: https://lore.kernel.org/r/20190827233017.GK9987@google.com > > drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c > index d6499763f0dd..937a843fed56 100644 > --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c > @@ -424,14 +424,14 @@ int iwl_mvm_init_fw_regd(struct iwl_mvm *mvm) > return ret; > } > > -const static u8 he_if_types_ext_capa_sta[] = { > +static const u8 he_if_types_ext_capa_sta[] = { > [0] = WLAN_EXT_CAPA1_EXT_CHANNEL_SWITCHING, > [2] = WLAN_EXT_CAPA3_MULTI_BSSID_SUPPORT, > [7] = WLAN_EXT_CAPA8_OPMODE_NOTIF, > [9] = WLAN_EXT_CAPA10_TWT_REQUESTER_SUPPORT, > }; > > -const static struct wiphy_iftype_ext_capab he_iftypes_ext_capa[] = { > +static const struct wiphy_iftype_ext_capab he_iftypes_ext_capa[] = { > { > .iftype = NL80211_IFTYPE_STATION, > .extended_capabilities = he_if_types_ext_capa_sta, Thanks for your patch! Though we already have this change in our internal tree (submitted by YueHaibing) and it will reach the mainline soon. -- Cheers, Luca.