mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Changbin Du <changbin.du@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	linux-kernel@vger.kernel.org,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH v6 1/2] perf: support multiple debug options separated by ','
Date: Tue, 26 Nov 2019 11:10:45 +0530	[thread overview]
Message-ID: <c22da5eb-71dd-511b-bc9a-4981c3b22d4c@linux.ibm.com> (raw)
In-Reply-To: <20191125151446.10948-2-changbin.du@gmail.com>



On 11/25/19 8:44 PM, Changbin Du wrote:
>   	List of debug variables allowed to set:
> -	  verbose          - general debug messages
> -	  ordered-events   - ordered events object debug messages
> -	  data-convert     - data convert command debug messages
> -	  stderr           - write debug output (option -v) to stderr
> -	                     in browser mode
> -	  perf-event-open  - Print perf_event_open() arguments and
> -			     return value
> +	  verbose=level		- general debug messages
> +	  ordered-events=level	- ordered events object debug messages
> +	  data-convert=level	- data convert command debug messages
> +	  stderr		- write debug output (option -v) to stderr
> +	  perf-event-open	- Print perf_event_open() arguments and
> +	                          return value in browser mode
Shouldn't this be:

	  stderr		- write debug output (option -v) to stderr
	  			  in browser mode
	  perf-event-open	- Print perf_event_open() arguments and
	                          return value

-Ravi


  reply	other threads:[~2019-11-26  5:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 15:14 [PATCH v6 0/2] perf: add support for logging debug messages to file Changbin Du
2019-11-25 15:14 ` [PATCH v6 1/2] perf: support multiple debug options separated by ',' Changbin Du
2019-11-26  5:40   ` Ravi Bangoria [this message]
2019-11-26 14:18     ` Changbin Du
2019-11-26  9:45   ` Jiri Olsa
2019-11-26 14:34     ` Changbin Du
2019-11-25 15:14 ` [PATCH v6 2/2] perf: add support for logging debug messages to file Changbin Du
2019-11-26  9:50   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c22da5eb-71dd-511b-bc9a-4981c3b22d4c@linux.ibm.com \
    --to=ravi.bangoria@linux.ibm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=changbin.du@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome