From: Su Hui <suhui@nfschina.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
maciej.szmigiero@oracle.com, yangyingliang@huawei.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ALSA: ac97: Fix possible NULL dereference in snd_ac97_mixer
Date: Wed, 23 Aug 2023 09:24:41 +0800 [thread overview]
Message-ID: <c2327680-b03c-ca95-b286-12a2e4b2c241@nfschina.com> (raw)
In-Reply-To: <49247018-20fe-8a04-75f2-dad4524aa3a3@wanadoo.fr>
On 2023/8/23 04:07, Christophe JAILLET wrote:
> Le 15/06/2023 à 04:17, Su Hui a écrit :
>> smatch error:
>> sound/pci/ac97/ac97_codec.c:2354 snd_ac97_mixer() error:
>> we previously assumed 'rac97' could be null (see line 2072)
>>
>> remove redundant assignment, return error if rac97 is NULL.
>
> Hi,
>
> why is the assigment redundant?
>
> Should an error occur, the 'struct snd_ac97 **' parameter was garanted
> to be set to NULL, now it is left as-is.
>
> I've checked all callers and apparently this is fine because the
> probes fail if snd_ac97_mixer() returns an error.
>
> However, some drivers with several mixers seem to rely on the value
> being NULL in case of error.
>
> See [1] as an example of such code that forces a NULL value on its
> own, to be sure.
>
> So, wouldn't it be safer to leave a "*rac97 = NULL;" just after the
> added sanity check?
>
Hi,
Really thanks for pointing this mistake.
this assignment is necessary and removing it may cause some problem.
So sorry for my mistake, I will send a patch to fix it right now.
Su Hui
>
> CJ
>
>
> [1]:
> https://elixir.bootlin.com/linux/v6.5-rc7/source/sound/pci/atiixp.c#L1438
>
>>
>> Fixes: da3cec35dd3c ("ALSA: Kill snd_assert() in sound/pci/*")
>> Signed-off-by: Su Hui <suhui@nfschina.com>
>> ---
>> sound/pci/ac97/ac97_codec.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
>> index 9afc5906d662..80a65b8ad7b9 100644
>> --- a/sound/pci/ac97/ac97_codec.c
>> +++ b/sound/pci/ac97/ac97_codec.c
>> @@ -2069,8 +2069,8 @@ int snd_ac97_mixer(struct snd_ac97_bus *bus,
>> struct snd_ac97_template *template,
>> .dev_disconnect = snd_ac97_dev_disconnect,
>> };
>> - if (rac97)
>> - *rac97 = NULL;
>> + if (!rac97)
>> + return -EINVAL;
>> if (snd_BUG_ON(!bus || !template))
>> return -EINVAL;
>> if (snd_BUG_ON(template->num >= 4))
>
next prev parent reply other threads:[~2023-08-23 1:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 2:17 Su Hui
2023-06-15 6:41 ` Takashi Iwai
2023-08-22 20:07 ` Christophe JAILLET
2023-08-23 1:24 ` Su Hui [this message]
2023-08-23 14:37 ` Takashi Iwai
2023-08-23 17:18 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2327680-b03c-ca95-b286-12a2e4b2c241@nfschina.com \
--to=suhui@nfschina.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.szmigiero@oracle.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®