From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932280AbdC1SVi (ORCPT ); Tue, 28 Mar 2017 14:21:38 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35584 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932207AbdC1SVg (ORCPT ); Tue, 28 Mar 2017 14:21:36 -0400 Subject: Re: [PATCH v2,2/3] tty/serial: meson_uart: add documentation for the dt-bindings To: Mark Rutland References: <20170328092545.4644-1-hgkr.klein@gmail.com> <20170328092545.4644-3-hgkr.klein@gmail.com> <20170328100551.GA24221@leverpostej> Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Helmut Klein Message-ID: Date: Tue, 28 Mar 2017 20:20:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170328100551.GA24221@leverpostej> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hallo Mark, i will add your text to the patch. Helmut On 28.03.2017 12:05, Mark Rutland wrote: > On Tue, Mar 28, 2017 at 11:25:44AM +0200, Helmut Klein wrote: >> Add the documentation for the device tree binding of meson_uart >> >> Signed-off-by: Helmut Klein >> --- >> .../bindings/serial/amlogic,meson_uart.txt | 25 ++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt >> >> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt b/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt >> new file mode 100644 >> index 000000000000..6f94ba25760d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt >> @@ -0,0 +1,25 @@ >> +* Amlogic Meson UART, used in multiple SoCs (e.g. S905, s905X, ...) >> + >> +Required properties: >> +- compatible : "amlogic,meson-uart" >> +- reg : offset and length of the register set for the device. >> +- interrupts : device interrupt >> +- clocks : the baud rate clock for the UART and optionally the core clock for the none AO uarts >> +e.g. >> +uart_A: serial@84c0 { >> + compatible = "amlogic,meson-uart"; >> + reg = <0x0 0x84c0 0x0 0x14>; >> + pinctrl-0 = <&uart_a_pins &uart_a_cts_rts_pins>; >> + interrupts = ; >> + clocks = <&xtal>, <&clkc CLKID_UART0>; >> + clock-names = "xtal", "core"; > > Please define these explicitly above, e.g. > > - clocks: a list of phandle + clock-specifier pairs, one for each entry > in clock names. > - clock-names: contains: > * "xtal" for the baud rate clock > * "core" for the non-AO UARTs (optional) > > Thanks, > Mark. >