From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD0352594B9; Tue, 21 Jul 2026 10:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784630860; cv=none; b=LlDWMJUdZglq7d15mhWLTozYIAjIR9ku9Ck5Pu3lyNy5BXFaGGJVn5/4715uAk/JWuvtqSuTDWCFYcIGaisTj+N6XlkEgBkEWRNof1BMriPxNtG+kxIYiUE04FyjeJ/9JYqbISC77ssElbhOuAJqf18ykVPUWxj5OJWGNiMIdnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784630860; c=relaxed/simple; bh=xzTM85RZtCEKJwBEdK41aziqAPtrKDr6GMJmPd65zLM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W/gg/LS6O5m00mrf6Su6kG+MyD28/z6qqNp0xZfkFHeper15SN1QKyv6I0/+eQOmMjogVvD+yhaQEVkfkGTKixxMROky8fpsWz+532Mj2GytAbJLhfVfWO3UUycF/lA2XZiL7fExFXM8sc9kGhUkt4GfTNSBMW3oAaD8CrKVQ3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=D9hKYERx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="D9hKYERx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BB821F00ADB; Tue, 21 Jul 2026 10:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784630841; bh=qiRn/EoXowNAFUb+/CMEqlELTbv2z1ktp+4yNterQHM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=D9hKYERxh9kQflnAdZPElpi7jsICi86hlzf3cfplZI4XcE1rILPch2S3QV4TSZS1+ 1Ndu5FI4yNrgfwjJdWPpnJcIjA9ZFl/IBVLk4BmYgkQi4oXyAzryvFGDPAyJmSzc+i T4st8JebReZDHffEST00qO2m2XD0zAmc4okz/sJZmAuKT5RNcbfWPg5ZrRqBRYEDEM ycEHsQwe9cCxpmxsqij2RgtSuihaH2TNwhT13tPOnlfss4WkosYLhwpJfY8SXxA0Et xgsTNdqmY1EFfYfZyfMjmVssD7Ee7lwFGz2rspepdog9wNqK1mTuXusFB5GB7914Bx k0MOyyevsAIpg== Message-ID: Date: Tue, 21 Jul 2026 11:47:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Vladimir Zapolskiy , Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260720-x1e-csi2-phy-v13-0-160c31958863@linaro.org> <20260720-x1e-csi2-phy-v13-1-160c31958863@linaro.org> <0da6d314-bfa9-493a-bcc6-8c3b75751d0c@linaro.org> <88ae6662-cb85-4e3a-bbb5-1b536348df34@kernel.org> <_t1jiMTX3iIXhUkTDz0Cbh_uZhdUK_Y8vlIwxt1VNRbuKuRnpVCWabal-b4AuFrVaKrDnQSFOWtDn6-VCbS3DA==@protonmail.internalid> <345ca98e-09f6-4965-87bb-e64dac096498@linaro.org> From: Bryan O'Donoghue Content-Language: en-GB Autocrypt: addr=bod@kernel.org; keydata= xsFNBGRJNSgBEADD7Vm2ZFa+v+JGJ2QYTJqQAkqis/uOHkhdFNXqpBarVBd47QU/DMNU5Rxg jedMQEmHoeDbJ6UOpjbrUQ63c5sgG1JbroHJJctwsEI75OOlekMuebEbjIJBLfgENGwPBMHv piv5TgCWr0VgYaXfp2eh2LINFywzqj823HiDPibQAXDrjzvF1ogksi/6cQZs8d4if8YQkLOr YISFouG+eR0nN1I7mUfIddXOWu6lJeTyqbWVurv58k2ekIXKaOC9ixLHFbcfYV0hOgRaTwQC B8CYF9nfqZla19iItfsN9QxN+ZdQjcRoYipp6HPCMfJlKH7GfaFcW93LKc4DKJ2lVL+pg/OQ lythZbjRPY492NG9kZ65aYstCs90uhMUEVVPuGUw7wBEku+6IEwZfrbMVKeWzLlPyM4Hv9hM 8ktxSmxWsPTPqpBC8eyeAQLalMELAyVcZlkaCtEcbj7w4l/JkYz+4l37obG8ZD+B34udBUUz MsAJ8foDFrBh2MOFA3hxD6G90D23mmWsri7pnKA2tZs92aQX7Ee+FbCyg6g5ln62Sq83ZDbf 53DdBs55EVpBadeInWmXhzCHPQx06H+CwTEjShTYIaMmBfrewvYUDKvFTC5iKQhAEUgt6i94 JsbG7NoeqcxkUMcBOEUQ3uCQG1D70ugspgXc0wd3Rimiq6535wARAQABzSFCcnlhbiBPJ0Rv bm9naHVlIDxib2RAa2VybmVsLm9yZz7CwZEEEwEIADsWIQTmk/sqq6Nt4Rerb7QicTuzoY3I OgUCZ+R+mwIbAwULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgAAKCRAicTuzoY3IOimUD/94 BwVEJX31JRe2sxbB/e1w2p8x1bxvTw5AeIzpV3ox7coJg1bSU2mnGuj1V4o0Yxf/3zmcJzCN VfVjwRF8Ii3GnC7uUXk2t+87piQfKTyJAYQABhZUKgoVJbjJq/S+C3XCKIyBA+EiezoUsgsA jTzwU+FzV7zVWIXFPJNtBERLwboE9w9U3KjAExOa1kSY8eLrsg6kOwlOHWy5UsQqYOjrS96M mzm2xuc1+RCjrndAyYhCnrOKvJ67HsPnBeJCjw7ImGD/U1GchwYbX8o3DO3JNHm3qfC86ZqX 2sCouENg4OzgPTtLKUrueM6xsu6KMM7gj17vxsiR3KQEoJnnMB8D1xtBofN3mFZE0wD9M24m 8yGunZbtntMCUHzIrlJgAPwKWKuGOYtA8UgMTFkccnUJtQrg9KotKtEF/FuftG9zLG9XEkt4 5ZdNgbSoLWgelu3T47mbOJ8LHhiLaCWP7yrovtVAvLUQ1BsiA42u8ECrFCFvQj9nrejE/ICv kP+uqcKtdDvP9HrIGycF1WZyfZLp0RvopKW92FLvI4I1QFWJ+wenk6+LGyJ5bzlrWzevjxmf nHcXE6sJBHrE7eijlbbImDAi3uLYN8Nd9Dm11IDAy4GAIQxSiQn0yblDhPiyGtchy80EVkCm g9k17Wol+2E2mC4DKgVdCkyUtTRSLgsJCs7BTQRkSTUoARAAuTnmWHBS6izRcEE93ajpzI7h dgQO4U3IRvOEsvIKR5NGcNEs0ngGebwsZ/lVULjN4vYU0LleqVhPBidNXUoZCN3A0F0Z2Ov8 NZdef+2EhQPBVWxFO7JBzhe8Z3ALj+wFtlg8akJjBzU56azW/iJzAobqHVrudzKoO2b1/CMg VbiAQ+RXjgfN5kY/HqYDU7mw+hXuUV9PbtX1L8xqQQac95oM9rHzKHHpiVwxTeJnGQsa+THi Kze+YET3rCoGHMvOQEJhdrucTv5FpAakKdkOFNel9FFckLRKEuWgCzhpFsjQ7xbirQgFUxG9 vlk1+q4hMRGNyEqoD6svYEeqbiUSd0oPUJeioiC3rNMRCNHLVrfZ2J6SCPkxfda08uzSdDQU 1/YPjOh8ZtQDMu7WctZ3XO288Z1gyBR49V7fbFs2w4sQxG+h/enlxqP7fdw1mjUlZjU5huCJ ielS0oEaIpmUpkugli7x4WhwLnhK2EbSoz7nLBC0y+ALUOdMlz/Y1l9xRt+bkDhpmf4O4IcI MxgZ0QMLq8rHDkGaEbsgZZHQPS58T0XE3IP30Q9SNxsruCMXtd2hYtBssf/wohc6JVsTtMg2 VYTPDPIFNZFSXupEJB7jlqpDWJ8ooJfJRLBatbjT5+mVQaMYB7Hs/t+zWYWaJKHyc8O6WLEC NUV5Tdt5EkkAEQEAAcLBdgQYAQoAIBYhBOaT+yqro23hF6tvtCJxO7Ohjcg6BQJkSTUoAhsM AAoJECJxO7Ohjcg6LuIQALnXt36OUuK43wqw6UYt0cnN6EbUqJHApAF5eNFn0jCCB2XELjSz JKJwuNAweowBdabiBniJ+501WIW+ewEsz1uby5fUQjZuCEsIkuaIluyfUFPb73qrQyAGuusd 7teA4WT+/jUku9g7lX5sVoRCrKQPkd16f6Bzfztyqyjcn43/X5yQI+wlboQ6HuKe/3I3yiOx OgmCHzOawpC9PvhEcKj79RLM3Zz5Ts5AuHpRX70Jz8Be76LwVFLp5Msx3S24ZTU1lBo2uiJ3 xSkay2lTpyVWRPx9vgcwzxGguOPJQJwsQeLb7wpoJMPpD3ERoaRii7Q7hvmxklpZjhKYWB3d t6nQ497Ek9loCrp3MIjRCSDN5xEGffiHks9yTeGMUQwO4tX8RE04uOJPkUY7uCFzFqN6/qey X3oFfPgkULMdiHofPAL1OskZSTzGPSfTYRE46NCJw8yoZBQ/oOyWeqaUQbK0wmW/g81wm8p7 LKSGEglMpiX07M1AotgvylN5C8fjbouoK+/RAMsXkk8jba6rPfuuXPaDjCyyKn6zSVHETnHW 3AJbgVY50T8STpnxayBQvWbCvu+6NOEjXCbyaOJig+5l0zlGN9XHjdANXC5HnwmyaGRL9YDq Jh2nVXVJDincOdQRdKcJjYLqaOAoWrYWSDi1iZGspHBTDrnOvfMQzzHY In-Reply-To: <345ca98e-09f6-4965-87bb-e64dac096498@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/07/2026 10:56, Vladimir Zapolskiy wrote: > On 7/21/26 12:39, Bryan O'Donoghue wrote: >> On 21/07/2026 09:17, Vladimir Zapolskiy wrote: >>>> + "#phy-cells": >>>> + const: 1 >>>> + description: >>>> + The single cell specifies the PHY operating mode. >>> This has been reported before, #phy-cells shall be 0, the operation >>> mode is selected by bus-type of endpoints as it is described in >>> video-interfaces.yaml >>> >>> Two competing values are redundant and it opens a door to a wrong >>> hardware description, the technical discussion has not been started yet. >> So as I said before, I'm following Rob Herring's input on this and >> Krzysztof has given RB for this binding. At this stage, I don't see >> scope to change it. >> >> Adding endpoints was already a compromise to address your feedback, >> which I hoped would bring you on board with the design. > That's my comment dated March 27, 2026, and it says moving phy type > from phy cell to the endpoint property excludes the need to set any > phy cells: > > https://lore.kernel.org/linux-arm-msm/e37ce438-12c7-462d- > b2bc-1351be62b806@linaro.org/ > > The technical comment is left unresponded so far since then. > > Since there is no expected phy cells to get on consumer's side, and > since there is another link between CSIPHY and CSID described in > video-interfaces.yaml, any kind of dependency of this IP on phy can > be just removed, which serves the purpose of hardware description > simplification. Rob's v1 feedback was consumer-decides-mode via the cell; Krzysztof has R-b'd the binding with cells=1. I'm happy to lock down this binding as-is on that basis. Are you arguing about phy-cells or are you actually arguing the entire instantiation of Qualcomm MIPI CSI2 as a standalone generic driver in drivers/phy ? Its not the same debate at all. As the CAMSS maintainer, I'm fully against adding more inline monolithic CSIPHY init sequences. That could be represented as a separate linux-media driver but, then that implies that _all_ upstream CSIPHY drivers in drivers/phy are wrong, and I just don't accept that. The bindings have DT maintainer RB, and the driver has Qcom engineer tested-by, review-by. Vinod, Kishon - Again, I'd request this merges as-is. --- bod