From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754553AbcGEKB0 (ORCPT ); Tue, 5 Jul 2016 06:01:26 -0400 Received: from zencphosting06.zen.co.uk ([82.71.204.9]:49932 "EHLO zencphosting06.zen.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbcGEKBW (ORCPT ); Tue, 5 Jul 2016 06:01:22 -0400 Subject: Re: [PATCH v2 8/8] Input: synaptics-rmi4: Use the RMI_F11_REL_BYTES define in rmi_f11_rel_pos_report To: Andrew Duggan , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <1466813992-16085-1-git-send-email-aduggan@synaptics.com> Cc: Dmitry Torokhov , Linus Walleij , Jiri Kosina , Benjamin Tissoires , Vincent Huang From: Nick Dyer Message-ID: Date: Tue, 5 Jul 2016 11:01:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466813992-16085-1-git-send-email-aduggan@synaptics.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-1.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - zencphosting06.zen.co.uk X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - itdev.co.uk X-Get-Message-Sender-Via: zencphosting06.zen.co.uk: authenticated_id: nick.dyer@itdev.co.uk X-Authenticated-Sender: zencphosting06.zen.co.uk: nick.dyer@itdev.co.uk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/06/2016 01:19, Andrew Duggan wrote: > The size of relative data in F11 is already defined by RMI_F11_REL_BYTES. > Use the define in rmi_f11_rel_pos_report() to be consistent. > > Signed-off-by: Andrew Duggan Reviewed-by: Nick Dyer > --- > drivers/input/rmi4/rmi_f11.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c > index 3fda75b..cce82a1 100644 > --- a/drivers/input/rmi4/rmi_f11.c > +++ b/drivers/input/rmi4/rmi_f11.c > @@ -530,8 +530,8 @@ static void rmi_f11_rel_pos_report(struct f11_data *f11, u8 n_finger) > struct f11_2d_data *data = &f11->data; > s8 x, y; > > - x = data->rel_pos[n_finger * 2]; > - y = data->rel_pos[n_finger * 2 + 1]; > + x = data->rel_pos[n_finger * RMI_F11_REL_BYTES]; > + y = data->rel_pos[n_finger * RMI_F11_REL_BYTES + 1]; > > rmi_2d_sensor_rel_report(sensor, x, y); > } >