From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E11E5C433EF for ; Mon, 20 Sep 2021 08:23:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7028610A3 for ; Mon, 20 Sep 2021 08:23:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235697AbhITIZX (ORCPT ); Mon, 20 Sep 2021 04:25:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235657AbhITIZR (ORCPT ); Mon, 20 Sep 2021 04:25:17 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE8D1C061574 for ; Mon, 20 Sep 2021 01:23:50 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id t8so27349899wrq.4 for ; Mon, 20 Sep 2021 01:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jA3PUfcB8IXDnqpW4ECqSitXcmSlkqlE5fXiosOJTOo=; b=FaBXEgEx8+bjza3Q5tKipeVR8HxfZxSGKrtz34erCdsVUaddUBaUM5u7wf07thayrT GLcm3wylnWpQD5S13RgvSlLyqi8xoTvHovPr+7f8eLw695aCraDhGx82gkE9zmzjLK2U kELSfQIgQ2fvzWv2Bqa0Ppcz939SlHR7tnFKxRYJ09t1KaJXhYbKISVpbGytIPrRcpoB B3IcP0EBQpYOcuaI8OSajxSyK9/LfCFjt+TdJns1/pfpHfjPZJujUbccOkHAnrCb6phd mMIoD9a9ZgQbjz2zZBVhBtGbfy7p/IxgtXwzlM5gxk5RKtzA+ogoeYYkQKGTWvnY6LTB S4SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=jA3PUfcB8IXDnqpW4ECqSitXcmSlkqlE5fXiosOJTOo=; b=dxZWR9fQb8GcOOejaJ0ZL4Aa9PkHvI24jurHtzIHDKgTx6AaAfrbj5c+Wxqfjh4XLD Bizsj8N2lnmbPOhtUwOmryTrG0yW+b2hND8KQZxvG6173rXkIX18LjR3MyiHHIVZTh4L J/WVJ6OwmyIsKJiKzUFpQDJOaPqB1WCCGg2GLW0HG2AxiGm1rwF4LhFk/Ja0LcmuV28v ex9Ab0o31rR8hFkI6i1jIc5r6U7ci/obWVbtv9Zhtphx9SeSKSbWoN9bVIXdGzzbQjqY /1Wmw8vIkyTX9PZO9AgGgpGwLmh2LvLWPVfk/kxZyymJEnC6XKfbAtSmPq+K476UgBGR NRbQ== X-Gm-Message-State: AOAM533WSaFUS9oDXn2G7C2Hfrz9J/hBJVS1kdPmSNUfKEdbCdVcH2Px 9veM4U4Bup3rVTmMVk2G0VJaGA== X-Google-Smtp-Source: ABdhPJyySDfp0Tt9vPlhMutYIwWn7eTnlpMOdM8CIDq3Yb1eS7BY8LfohWnuU/6TFFPPEdPUsNTHow== X-Received: by 2002:a5d:64ab:: with SMTP id m11mr24719653wrp.343.1632126229497; Mon, 20 Sep 2021 01:23:49 -0700 (PDT) Received: from [172.20.10.7] ([37.169.24.17]) by smtp.gmail.com with ESMTPSA id y64sm11852384wmc.38.2021.09.20.01.23.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 01:23:49 -0700 (PDT) Subject: Re: [PATCH] arm64: dts: meson-g12b-odroid-n2: add 5v regulator gpio To: Anand Moon , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , devicetree@vger.kernel.org References: <20210919213135.4928-1-linux.amoon@gmail.com> From: Neil Armstrong Organization: Baylibre Message-ID: Date: Mon, 20 Sep 2021 10:23:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210919213135.4928-1-linux.amoon@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 19/09/2021 23:31, Anand Moon wrote: > As described in the Odroid-n2 & Odroid-n2-plus schematics, > the 5V regulator is controlled by GPIOH_8 and in Open Drain > since this GPIO doesn't support Push-Pull. > Fixes: c35f6dc5c377 ("arm64: dts: meson: Add minimal support for Odroid-N2") Fixes: ef599f5f3e10 ("arm64: dts: meson: convert ODROID-N2 to dtsi") > Cc: Neil Armstrong > Signed-off-by: Anand Moon > --- > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > index 4f33820aba1f..e8a00a2f8812 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > @@ -99,6 +99,8 @@ vcc_5v: regulator-vcc_5v { > regulator-max-microvolt = <5000000>; > regulator-always-on; > vin-supply = <&main_12v>; > + gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>; > + enable-active-high; > }; > > vcc_1v8: regulator-vcc_1v8 { > Exact I wonder how I missed this.... Acked-by: Neil Armstrong Thanks, Neil