From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v3 5/7] mfd: Add Device Tree bindings document for TI tps6105x chip
Date: Tue, 4 Apr 2017 07:48:48 -0400 [thread overview]
Message-ID: <c2496732-b72d-e8f6-9b1d-2c06848fda07@osg.samsung.com> (raw)
In-Reply-To: <20170404082739.6w6ltgdr2mgaqq4l@dell>
Hello Lee,
On 04/04/2017 04:27 AM, Lee Jones wrote:
> On Mon, 03 Apr 2017, Javier Martinez Canillas wrote:
>
>> Hello Lee,
>>
>> On 04/03/2017 07:15 AM, Lee Jones wrote:
>>
>> [snip]
>>
>>>> +
>>>> +The TP61050/TPS61052 is a high-power "white LED driver". This boost converter
>>>> +is also used for other things than white LEDs, and also contains a GPIO pin.
>>>
>>> What functions does it offer?
>>>
>>
>> Same comment than before, I'm not really familiar with this driver. But I'll
>> look what are the MFD cell instantiated to better understand dev functions
>> and expand this documentation accordingly.
>
> Writing documentation for H/W you are unfamiliar with is a bad idea IMHO.
>
I just wanted to add an OF device ID table to the driver to make sure the
driver won't have a regression when the I2C core reports an OF modalias
but was asked to also write a DT binding doc in this case...
I'm happy to drop the DT binding doc patch and someone more familiar to do
it as a follow up.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2017-04-04 11:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 7:18 [PATCH v3 0/7] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
2017-04-01 7:18 ` [PATCH v3 1/7] mfd: Add Device Tree bindings document for retu/tahvo ASIC chips Javier Martinez Canillas
2017-04-03 11:13 ` Lee Jones
2017-04-03 15:40 ` Javier Martinez Canillas
2017-04-01 7:18 ` [PATCH v3 2/7] mfd: retu: Add OF device ID table Javier Martinez Canillas
2017-04-03 11:15 ` Lee Jones
2017-04-03 15:45 ` Javier Martinez Canillas
2017-04-03 22:20 ` Rob Herring
2017-04-03 22:24 ` Javier Martinez Canillas
2017-04-03 22:53 ` Aaro Koskinen
2017-04-03 22:58 ` Tony Lindgren
2017-04-03 23:00 ` Javier Martinez Canillas
2017-04-01 7:18 ` [PATCH v3 3/7] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Javier Martinez Canillas
2017-04-01 7:18 ` [PATCH v3 4/7] ARM: dts: n8x0: Add vendor prefix to retu node Javier Martinez Canillas
2017-04-01 7:18 ` [PATCH v3 5/7] mfd: Add Device Tree bindings document for TI tps6105x chip Javier Martinez Canillas
2017-04-03 11:15 ` Lee Jones
2017-04-03 15:47 ` Javier Martinez Canillas
2017-04-04 8:27 ` Lee Jones
2017-04-04 11:48 ` Javier Martinez Canillas [this message]
2017-04-01 7:18 ` [PATCH v3 6/7] mfd: tps6105x: Add OF device ID table Javier Martinez Canillas
2017-04-01 7:18 ` [PATCH v3 7/7] ARM: ux500: Add vendor prefix to tps61052 node Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2496732-b72d-e8f6-9b1d-2c06848fda07@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®