From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>, lihaiwei.kernel@gmail.com
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
joro@8bytes.org, Haiwei Li <lihaiwei@tencent.com>
Subject: Re: [PATCH] KVM: vmx: add mismatched size in vmcs_check32
Date: Thu, 8 Apr 2021 18:28:45 +0200 [thread overview]
Message-ID: <c24c9d96-37c5-cfb4-8b84-cb3f8daee500@redhat.com> (raw)
In-Reply-To: <YG8pwERmjxYQoquP@google.com>
On 08/04/21 18:05, Sean Christopherson wrote:
> Add compile-time assertions in vmcs_check32() to disallow accesses to
> 64-bit and 64-bit high fields via vmcs_{read,write}32(). Upper level
> KVM code should never do partial accesses to VMCS fields. KVM handles
> the split accesses automatically in vmcs_{read,write}64() when running
> as a 32-bit kernel.
KVM also uses raw vmread/vmwrite (__vmcs_readl/__vmcs_writel) when
copying to and from the shadow VMCS, so that path will not go through
vmcs_check32 either.
Paolo
next prev parent reply other threads:[~2021-04-08 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 7:54 lihaiwei.kernel
2021-04-08 16:05 ` Sean Christopherson
2021-04-08 16:28 ` Paolo Bonzini [this message]
2021-04-09 1:57 ` Haiwei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c24c9d96-37c5-cfb4-8b84-cb3f8daee500@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=lihaiwei.kernel@gmail.com \
--cc=lihaiwei@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®