Re: [GIT PULL] platform-drivers-x86 for 5.11-1

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 12/16/20 1:17 AM, Linus Torvalds wrote:
> On Mon, Dec 14, 2020 at 4:43 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> - New Intel PMT telemetry and crashlog drivers
> 
> These have _very_ annoying Kconfig setups.
> 
> First it asks about INTEL_PMT support.
> 
> If you say no, it then asks about INTEL_PMT_CLASS, INTEL_PMT_TELEMETRY
> and INTEL_PMT_CRASHLOG support.

Yeah that is bad, sorry for not spotting that (I answer M/Y everywhere
so that I at least compile test everything).

> I've pulled this,

Thanks.

> but I really wish the PMT support understood that
> whole "No means no" thing.

Agreed. I will make sure to get a fix to you for this sometime
during the 5.11 cycle.

Alexander and/or David I believe that the best solution for this
would be to replace the:

        select INTEL_PMT_CLASS

In the INTEL_PMT_TELEMETRY and INTEL_PMT_CRASHLOG Kconfig entries
with "depends on". Also as a general comment for the future, select
should typically be used with non-user-selectable options. E.g.
you could also have made INTEL_PMT_CLASS non-user-selectable by
changing:

config INTEL_PMT_CLASS
        tristate "Intel Platform Monitoring Technology (PMT) Class driver"

To:

config INTEL_PMT_CLASS
        tristate

Having both INTEL_PMT_CLASS user-selectable and using select on
it is bad. I believe that in this case changing the 2 "select"-s
to "depend on"-s is best.

Regards,

Hans