From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A5153398 for ; Fri, 28 Jun 2024 20:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719607664; cv=none; b=ZIdJtaF8r+NUIl+Akh/WNnoG6FF4jCeChhDanmvEs9cEvH5lbsRCBuZEQ7wKP8oA4cbzShZIcEcRb8MaZL4E+XdV8f9eqbh66A8464OteKph922hlLlHb0fb6gufYYlb9aiGdW6fhQTFhnPM9cmo9nA7CxiIfLCKHErTyhMihUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719607664; c=relaxed/simple; bh=NQlio7vdY/v+4Pph9BxET0lpVLYx2s2xwxd4M9X+TgU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uWT1xU0+8z9TcKI36NSt9I1KLARLVAHFMEq4+PRjNaOeefIHwCSQLXzwsVVXRqxGQtTYXUCz09S52FB6fJQuI9F1r20+F1fTq52+AdUnMffXLRlmknN52nF7CmoSjYnwDbJRanZoW9WcvKZROqSIrQyq72KeylTFcQ9cNMG3/00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ThNVsoFn; arc=none smtp.client-ip=209.85.166.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ThNVsoFn" Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-375dea76edaso632525ab.2 for ; Fri, 28 Jun 2024 13:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1719607662; x=1720212462; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RVbzw5/lfJr1zoZUcLthvORO3HlmTqGHkbTzKCG2AtE=; b=ThNVsoFnRZ7JHUhYG5Yp/g3Af70N3X9oSS0syyTjIJ2wQDQsm1grMS2pvI82Lg0t19 RSYiKiRxm77o89MLZ7a291CuavEtaGa8S2uc9ROaQBYKEoIDdF7nthrfwWhGm3gO2J1t dpNhewkEQmvygR5sbD+PNn9gfe52qKXD7lvsE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719607662; x=1720212462; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RVbzw5/lfJr1zoZUcLthvORO3HlmTqGHkbTzKCG2AtE=; b=Ky0yJyPwbJXyFG4ASLP3dMbnK964r6t8VDyoJ7HSdJFSRW98G0iohVCVRE5rUaz+SY wNzZ1Zgk/okg59XX+TuzMarh2ONehVecLeRa/TU+79OIvlmiK9wFH0aILt3trBo08cEe QeKK/EFfIX90HtQv7DpGGxMekE1PSx16bvXct1J4pCgM+J5jnE06JYmlPT4BzzONKJB3 XQ2VlASODlRZu9IG18IxNP9vri0XB2msvzza/MljjIr2usuV3Cko/U8c5Mz5By39utk7 Y930bTZpKq55Eb/JiVh25B2N7ZQ4pgwrT83R2VpsGBYisiSMhJL2EIcCqdyKfv62n3R5 dmqg== X-Forwarded-Encrypted: i=1; AJvYcCXb+qZ+Mq8bxXzzIiRj/BT+69/zghHzTuAJVnQWzTQ5a8I/Waa52mQ8PtGS+4+cDtL8UPIcMKtGpRvrd+EKsn3BuZwdsekggc1F01HG X-Gm-Message-State: AOJu0YwXB4lD3Q0meF2nJm1DqV8xNAGtbhF/rqRvtaHGYYVFBvVNRp0i TTMp9LE6MvzDCXthfPOFtWNxUrzQznkCOYxvY2skjqqCDr6fmsWZtpyzIXq0mCc= X-Google-Smtp-Source: AGHT+IE4ELhZPGkhF2SpPfk2FPsx6NXVVUYlTOMjU7DLZNr/ofq6BA+1WUSb3ogxRZDrJIEMYmNz0w== X-Received: by 2002:a05:6602:25d7:b0:7eb:66a5:d1c with SMTP id ca18e2360f4ac-7f39c44f029mr1784506539f.0.1719607661845; Fri, 28 Jun 2024 13:47:41 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4bb73f90ed8sm699183173.99.2024.06.28.13.47.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jun 2024 13:47:41 -0700 (PDT) Message-ID: Date: Fri, 28 Jun 2024 14:47:40 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] cpupower: Add 'help' target to the 'debug/i386' subproject makefile To: Roman Storozhenko , Thomas Renninger , Shuah Khan Cc: Javier Carrasco , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240623-make_help_rest-v1-0-4bd3fd51064b@gmail.com> <20240623-make_help_rest-v1-4-4bd3fd51064b@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240623-make_help_rest-v1-4-4bd3fd51064b@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/23/24 13:19, Roman Storozhenko wrote: > Add 'help' target, describing all user-available targets, to the > 'debug/i386' subproject makefile. > > Signed-off-by: Roman Storozhenko > --- > tools/power/cpupower/debug/i386/Makefile | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/tools/power/cpupower/debug/i386/Makefile b/tools/power/cpupower/debug/i386/Makefile > index b3f771039b17..361265170986 100644 > --- a/tools/power/cpupower/debug/i386/Makefile > +++ b/tools/power/cpupower/debug/i386/Makefile > @@ -39,4 +39,16 @@ install: > $(INSTALL) $(OUTPUT)dump_psb $(DESTDIR)${bindir} > $(INSTALL) $(OUTPUT)intel_gsic $(DESTDIR)${bindir} > > +help: > + @echo 'Build targets:' > + @echo ' all - Default target. Could be omitted. Put build artifacts' > + @echo ' to "O" cmdline option dir (default: current dir)' > + @echo ' install - Install previously built project files from the output' > + @echo ' dir defined by "O" cmdline option (default: current dir)' > + @echo ' to the install dir defined by "DESTDIR" cmdline' > + @echo '' > + @echo 'Clean targets:' > + @echo ' clean - Clean build artifacts from the dir defined by "O" cmdline' > + @echo ' option (default: current dir)' > + > .PHONY: all default clean install > I don't see a value in adding this - these are common targets and nothing new about them. thanks, -- Shuah