From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33EF740BCDA for ; Tue, 30 Jun 2026 12:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782823356; cv=none; b=sI2WkOeJ9PlN3RM/UStA9/mUT+Rw+a5igae3mG040RLEYzD8+tBnJsseauHjw1JY3VZrof0P3luF5Jah89r4sSNVkMCnEMjIKwStIXNbj/ByMa8tjDb37LDh2vWbXz5YszEuU8ZK+SBuahWu/NKeVSFrw2MLMt1pgcDJwvPr34E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782823356; c=relaxed/simple; bh=yXo31lS3cpuo1i5+M8ce0VVveEoe0x91tJ+wogkxxl8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XgBDBb4/1HmmmEyy9iahQu5n8ZIz7p+JRUMU7QSppMckIsQwGSmrHyjI2GUU9QcGK/Bwi1U7kHgGJHIVPTj2Ml/GOcPWxAvX8hLzfMylPQwe22A4Fx6Swdox1e2y5MFmOmBIRF7cyY2GIrE6me5kRFdPQPhAmD771h8vqx2yiVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FDALlAFD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JeiDAxT9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FDALlAFD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JeiDAxT9" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9n0Cl1613515 for ; Tue, 30 Jun 2026 12:42:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vqgiAyPpNCB0A0IntH53l4iOkxkfpMU8dkDpi4Z9XyI=; b=FDALlAFDR7huBxwd WpIQ6SpAtlJNosB/BjBaKCGSCxBr9UYGDgxAea5BPhA/iJxfpFmvJ7NPOpawWx90 pSel/yL0Hy9QAJ85bUk+hw0x7kvr04y2alpgbaiqNd3LoZygWGn3rcAfEMyWuuQS AaPFT6C5b+WfoAzB2ITk9au9cNNvVTfsSpFdP+zhh9thg3RcFEqDJlKYgwufpqxO +44/GUDjNzNBntgDtsGCCSZe53+bCRnzDu2qDe+sLpFixkaqrd1yKCNbNQyysm/V Rtn5XnXLAFjqIECmh2rqZt1brTWzVH5CiDI1CUZi9idMKEpcEz8dvnZfx8DK6af4 7fbMVQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3x1cuw1u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 12:42:33 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c15c77619so1153441cf.1 for ; Tue, 30 Jun 2026 05:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782823352; x=1783428152; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vqgiAyPpNCB0A0IntH53l4iOkxkfpMU8dkDpi4Z9XyI=; b=JeiDAxT9jqOp1sROwe8J/hA3O80FqyhyqeS1H9v9JZIMUu+jHgOG9bx8i77i8lnlRD E0qqUka+OlpB//OaiapaqInlJaHYLe6NCVtPolf9TqLXOcvkjZii6OJJKmImwR0Mk+1R 3sRJHscprTSNfZhDx952ByUEIElpzt4Wdk0CmCd7DCTXhWf6W/1AeLb5HOjJvAn5yrYt D9Tl4un+hoaTj0MovQxicGrF2iSpdDwvPJlGdlsd1GwNaWcP68ujY9XrsbEI8ucKIpFO AnFDSVLA1OQ5ZMqFTu4GjNPvEI/enypP/bKZUBBgJ89UwoH5hJi9yvBCG1T7H9nOEAse h5hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782823352; x=1783428152; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vqgiAyPpNCB0A0IntH53l4iOkxkfpMU8dkDpi4Z9XyI=; b=PKqtHWmXOmvh2Q2nEMJ7Pyii3qtdZtI2Clem6owi70YSfDdm91cGMsaIiE4x2HjQNf Sa6irIlE2V8iZBWLkLy5W8D5rTJb213QsflI9BqAvm0Tw+Z8EHulfHM6M/gZICyuHZUJ ZILYyOPe2IarGGxX0xFM+WwWn2pKjAEjK3dexejwLQzznBuovx1YwrFdTVeK3DUIpJp2 8oMRyjixbpHQIbYlH4X5aQr7n1MS5aj0Nr+rrqh19OyU+jlgJCkwO6uCLxD64oFFkKos aOr+zDGzAULU/n6Hml9paUSqIcS/jm0l5IqusrJqWboWCPtdQLYoNspV+1JOigb6OUe5 z83w== X-Forwarded-Encrypted: i=1; AFNElJ87O4lVw0s0w1n2m+UC/7CCM5JOu60OyjRRo4E6gQJW61OWLpFFhRS4UHVeCqKQG22ZofVrfS0ZP3SkfVI=@vger.kernel.org X-Gm-Message-State: AOJu0YzUhkEc8Goz3DUcgkCob/uuxmT6BlyhTrvwgsuu9DDW02NsRdmh w1RxuOFs3CUHoopxzQ8CqumoQdkANdELTx9WoZ+nXtSB8q768yG2PlGVVhh0vU8kKIHlNWKo6Xe LaO5CEk5HKy/fiq1QdKqYUTij05/ElAa/XItUN2RyQgbp3se6Z9BXZuV2tku4tfY8h9w= X-Gm-Gg: AfdE7cmdf9sZJX0DZZXvCEuw23Er93pztrcRuMHO94lUjuxleKrLNKBxTQhonhSpAnC E5U/CreysAXQCSTUCID6L3VFf6MbZUgE2Sul1Iua1iH5XDk7f56WKvvaUykEoILiAdActOR54MK TlQ+hghru73CddNlZlLBC2Mz04oJFZFrlDpn6QHUHThGRtfOYCWEx1TTVY66RVWZVGLKzw5vUo1 EjQPwkBozg1KPB78oI1OwMq/PbQwcutsirk8J12RNqASqbMLhQd6k7eCmvxWVUo/Js9S1OufMrB 5nzJCwQg4wkxtF0SZ0a55OdqKkqVgBxa8jGWjHwVYdxuDOpH67xZ2YBz1YtCL2HtxLeBQa1qQjW B3FCSVQJ4b/edmFDHuQR0t8nP/DzmnuVwocE= X-Received: by 2002:ac8:7fc9:0:b0:51c:215:3e81 with SMTP id d75a77b69052e-51c10754ef1mr27550361cf.4.1782823352495; Tue, 30 Jun 2026 05:42:32 -0700 (PDT) X-Received: by 2002:ac8:7fc9:0:b0:51c:215:3e81 with SMTP id d75a77b69052e-51c10754ef1mr27549891cf.4.1782823351774; Tue, 30 Jun 2026 05:42:31 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288f4c19esm118502566b.51.2026.06.30.05.42.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 05:42:30 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 14:42:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 10/14] media: qcom: Pass proper PAS ID to set_remote_state API To: Sumit Garg , andersson@kernel.org Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg References: <20260626133440.692849-1-sumit.garg@kernel.org> <20260626133440.692849-11-sumit.garg@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260626133440.692849-11-sumit.garg@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDExNiBTYWx0ZWRfX+2i0wbyfY8z1 BDQVYYBQqrA3jRpui03awXCftkCJA8Zh7g1Q3FoyhE3p4mppRCJEkr/1g1jnrS5AcyXnWh7jSoq nk0Ng2a03vhHxYqRHJn/lP/vzFlOYJIH7N4qgYPCw/eXikGrS3B0hr8pG108uv0uwuVwhlmdQYp jFDTkTdB9cx9kZzmsXPed9Q6nVjHYy0UrDdQrsaXTlc8ElZsxHMddvAIEBw5qOffG3G4dZg68UA VNejjhvtBL0JP3q9wQ9BXnhGvEWymtPSNwfO/lMW8Hsc1X8fr7cwPs5+coJh0P7vXgZvfE5AVKL 44mSFX/iQ2JP1UcVsevYr6M0mE1Ae0zAUJRyjcqupUDeLuPxs7xP6xF2Cug764AQAthB2AZP53t 4DTQz8W40WK82sG8/3O+OLiLJWmRqDTyaC5EB3FzNlsPS4NX4lk+jflYdsqAWwDY4hGujMwYXuO f/IQvZqOom20TUqkw0g== X-Proofpoint-ORIG-GUID: l2maDs6I4QPmUFF_olDARq17Py7JUk4O X-Proofpoint-GUID: l2maDs6I4QPmUFF_olDARq17Py7JUk4O X-Authority-Analysis: v=2.4 cv=ftfsol4f c=1 sm=1 tr=0 ts=6a43b9b9 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=XI7qjyBPQyksM17I1wMA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDExNiBTYWx0ZWRfX4gaNuLU3w2Bk pBBZnxnOoKHJyMuoVBox13JaDW/oxJw8EXZwUDPrUP/OJo+FUBqfWV8TpAMPeiszIUA0V2geINT LoyuDdh8l3JaY2sG+HmKZYHyBMEMFMU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300116 On 6/26/26 3:34 PM, Sumit Garg wrote: > From: Sumit Garg > > As per testing the SCM backend just ignores it while OP-TEE makes > use of it to for proper book keeping purpose. > > Reviewed-by: Mukesh Ojha > Tested-by: Mukesh Ojha # Lemans > Reviewed-by: Vikash Garodia > Signed-off-by: Sumit Garg > --- > drivers/media/platform/qcom/iris/iris_firmware.c | 2 +- > drivers/media/platform/qcom/venus/firmware.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c > index ea9654dd679e..d2e7ba4f37e3 100644 > --- a/drivers/media/platform/qcom/iris/iris_firmware.c > +++ b/drivers/media/platform/qcom/iris/iris_firmware.c > @@ -110,5 +110,5 @@ int iris_fw_unload(struct iris_core *core) > > int iris_set_hw_state(struct iris_core *core, bool resume) > { > - return qcom_pas_set_remote_state(resume, 0); > + return qcom_pas_set_remote_state(resume, IRIS_PAS_ID); > } > diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c > index 3a38ff985822..3c0727ea137d 100644 > --- a/drivers/media/platform/qcom/venus/firmware.c > +++ b/drivers/media/platform/qcom/venus/firmware.c > @@ -59,7 +59,7 @@ int venus_set_hw_state(struct venus_core *core, bool resume) > int ret; > > if (core->use_tz) { > - ret = qcom_pas_set_remote_state(resume, 0); > + ret = qcom_pas_set_remote_state(resume, VENUS_PAS_ID); This should not be in the middle of a mildly related series.. The PAS IDs should be centralized into a single header. And the name of the driver shouldn't be part of the define. I would guesstimate that on the secure side it's probably called VPU or VIDEO Konrad