From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCC428F48 for ; Tue, 21 Oct 2025 09:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761038714; cv=none; b=UTirHTR5+m+wkADYwr4ZC0BADEzKe4g83GC0mmD+84zaChqX7rA0rBexUbl0Jf82xtpqAfFgH222+oQQbXTFuBYhLQwhRd8ZTO694Dd10tkm5AtQZEHhrqMEZjq5bXoCTPI6F0zz/0gULiAzCghlosVHm63bRMnKbF1/3p3skV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761038714; c=relaxed/simple; bh=70fh7l0TLwEingT0Dlsm17GX58QH+efSGCknR2mPUfQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OOlBcxEj3OK1IkNbVMJdsPM9UUghBLcCW5cTQkngZ5df3C2eFXqPBSjPbh81biyW0d6Rsd47AOfES8astCVbt5230tsWDAw2mPSd9oH57r55u+pPsSWUckZM7p4LlcLxVESKc/y8zCoyVj3ioM73iAj2iFqkNJbOgsSl3Fr9KFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Waxd1GKO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Waxd1GKO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761038711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4RANMdE5VJt3ZJzx3yGMY3tj7r6cm2tCoc3fFUR1o9c=; b=Waxd1GKOmZORm9wGxuuEenpLRd2wDC8mu12YYx9O64VnlQmArRyZP/38VnH+9QcmD1ejBF wVVFwo9qQw+Gk8hULL+UHrAKCLqwUEFyhxfweH3nZtxRq7XGYlYiDDq4W2TTzyppgwI3+i FDXLq/h0uoF/SAtrHp8q4asvx5CPbM4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-f1qVaJjxNwmh7SwNkU4S-Q-1; Tue, 21 Oct 2025 05:25:10 -0400 X-MC-Unique: f1qVaJjxNwmh7SwNkU4S-Q-1 X-Mimecast-MFC-AGG-ID: f1qVaJjxNwmh7SwNkU4S-Q_1761038709 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3ecdb10a612so6016468f8f.2 for ; Tue, 21 Oct 2025 02:25:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761038709; x=1761643509; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4RANMdE5VJt3ZJzx3yGMY3tj7r6cm2tCoc3fFUR1o9c=; b=B8NWrqJnCm4eq0IBYcInb9rdbvsQmqmMv5cHrLCsaL3Y13izNTg5onZ6Pyna6aAPM2 wMe4CpUEWr8ZFiw6cweLM4YFaDRAz2syzmb34axtyjemmgxCLy4JeHjpY1tik+sGN++D AamQb/7g3AuFSTCTJrrjueBkJI7JHf2SmDHrnE4f7+T5PXUwtQU084i1fYkFwTOcSEIW AVwSHephyxvP14V/cYfhTFlTK7OuSFhrBr4Ll3KoINXoxpynA8tNuT8TShiQ0uk0Ux8e EwjrK1tYymIhuoSlh7tP+GQO2KS/Ou240k/FzpONX1Cfk4l+w5eJ2ADuj+K2Dxh/Cq2Z Ra9g== X-Gm-Message-State: AOJu0Yy7cv6i1lyuxy+LGAlVUie5ZmURcsM/pbks0742GlKakuYecnt1 X8Sgq8LhxAF+R7Qt8G2InfhjxhHQu/7vJlSbdzFnYHxNyV6Y50+Icb8lVF/dUOH6DvOhwttE41f Uw8K4hrK/RRrkWWstTht0gIerInKU3S4Qzix8N7MH7Y+d/EROu8+LZ8qLoikNtfF/Jw== X-Gm-Gg: ASbGncufvX3ANavdx23u3tUxwCcgR1quJxH1d06lyeDYnrR89N+C8BC8L2H5TJq8IBr Kvi/cJPecbOOp5g7kYV0T5a7SpaZFttlo/lyqZwyWisPMx/CV0sJbBfdMZvcWkzqxVJQW1R65L2 ereH1XhsI7tQ4r3a92qjFBX+YWukHkBbjdJzcK1o9B8aGOZbr9rV+J/V0ux7zaz36qllDGqZJZx 0wVvysdy27aKVq0loC/M/FUJ2nP2Pvt12J3fjbh0GmN6MUWLgRmBcdn5+J30fc6XwFTYxN+EGtT pWiKjiHwW6XwW5BHahaHwsErx2JWie10xc9GVojw9gQYPYpgsG9t0uI4/+KjhWtFbJI97GGJpC7 fv6XhPyxFirPcOOdw1AoDVUxE/z0J2ezyu1uT6aevboRMW/o= X-Received: by 2002:a05:6000:22c6:b0:3ec:db18:1695 with SMTP id ffacd0b85a97d-42704dc9395mr11530736f8f.45.1761038709187; Tue, 21 Oct 2025 02:25:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEW/8VpN7+oRVVI2gacXOhu1lhYOkSBU8WbVYkhEZvqfdiTjdCOVwmyWkwuv1K6C+wnD9GcTg== X-Received: by 2002:a05:6000:22c6:b0:3ec:db18:1695 with SMTP id ffacd0b85a97d-42704dc9395mr11530698f8f.45.1761038708787; Tue, 21 Oct 2025 02:25:08 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427ea5a0f88sm18692002f8f.7.2025.10.21.02.25.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 02:25:08 -0700 (PDT) Message-ID: Date: Tue, 21 Oct 2025 11:25:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v02 2/6] hinic3: Add PF management interfaces To: Fan Gong , Zhu Yikai , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Andrew Lunn , Markus.Elfring@web.de, pavan.chebbi@broadcom.com Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, luosifu , Xin Guo , Shen Chenyang , Zhou Shuai , Wu Like , Shi Jing , Luo Yang , Meny Yossefi , Gur Stavi References: <8ad645360ce86569ec9c2c6532441352c06bc44a.1760685059.git.zhuyikai1@h-partners.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <8ad645360ce86569ec9c2c6532441352c06bc44a.1760685059.git.zhuyikai1@h-partners.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/17/25 10:30 AM, Fan Gong wrote: > diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h b/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h > index 78cface6ddd7..58c0c0b55097 100644 > --- a/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h > +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.h > @@ -39,24 +39,25 @@ struct hinic3_pcidev { > }; > > struct hinic3_hwdev { > - struct hinic3_pcidev *adapter; > - struct pci_dev *pdev; > - struct device *dev; > - int dev_id; > - struct hinic3_hwif *hwif; > - struct hinic3_cfg_mgmt_info *cfg_mgmt; > - struct hinic3_aeqs *aeqs; > - struct hinic3_ceqs *ceqs; > - struct hinic3_mbox *mbox; > - struct hinic3_cmdqs *cmdqs; > - struct delayed_work sync_time_task; > - struct workqueue_struct *workq; > - /* protect channel init and uninit */ > - spinlock_t channel_lock; > - u64 features[COMM_MAX_FEATURE_QWORD]; > - u32 wq_page_size; > - u8 max_cmdq; > - ulong func_state; > + struct hinic3_pcidev *adapter; > + struct pci_dev *pdev; > + struct device *dev; > + int dev_id; > + struct hinic3_hwif *hwif; > + struct hinic3_cfg_mgmt_info *cfg_mgmt; > + struct hinic3_aeqs *aeqs; > + struct hinic3_ceqs *ceqs; > + struct hinic3_mbox *mbox; > + struct hinic3_msg_pf_to_mgmt *pf_to_mgmt; > + struct hinic3_cmdqs *cmdqs; > + struct delayed_work sync_time_task; > + struct workqueue_struct *workq; > + /* protect hwdev channel init and uninit */ > + spinlock_t channel_lock; > + u64 features[COMM_MAX_FEATURE_QWORD]; > + u32 wq_page_size; > + u8 max_cmdq; > + ulong func_state; The above is a nice way to hide a single line addition. Please either avoid the reformatting entirely (preferred) or do the re-indentation in a separate pre-req patch. /P