From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: zhuyinbo <zhuyinbo@loongson.cn>, Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liu Peibao <liupeibao@loongson.cn>,
devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn,
Mark Brown <broonie@kernel.org>,
Jianmin Lv <lvjianmin@loongson.cn>,
Rob Herring <robh+dt@kernel.org>,
wanghongliang@loongson.cn
Subject: Re: [PATCH v1 1/2] dt-bindings: spi: add loongson spi
Date: Fri, 10 Mar 2023 10:08:57 +0100 [thread overview]
Message-ID: <c254b2f1-2086-498f-35c6-c87d838bcb2d@linaro.org> (raw)
In-Reply-To: <1f14658a-5dc3-fc48-5291-28e14f88abaa@loongson.cn>
On 10/03/2023 03:31, zhuyinbo wrote:
>
> 在 2023/3/8 下午10:06, Rob Herring 写道:
>> On Wed, 08 Mar 2023 10:59:07 +0800, Yinbo Zhu wrote:
>>> Add the Loongson platform spi binding with DT schema format using
>>> json-schema.
>>>
>>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
>>> ---
>>> .../bindings/spi/loongson,ls-spi.yaml | 47 +++++++++++++++++++
>>> MAINTAINERS | 6 +++
>>> 2 files changed, 53 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml
>>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Error: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dts:22.28-29 syntax error
>> FATAL ERROR: Unable to parse input tree
>> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dtb] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [Makefile:1512: dt_binding_check] Error 2
>>
>> doc reference errors (make refcheckdocs):
>
> This yaml patch need depend on
>
> https://lore.kernel.org/all/20230307115022.12846-1-zhuyinbo@loongson.cn/
>
> , then yaml compile will be successfull.
Nothing in the patch changelog (where it is preferred), not even cover
letter, mention dependencies.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-10 9:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 2:59 [PATCH v1 0/2] spi: loongson: add bus driver for the " Yinbo Zhu
2023-03-08 2:59 ` [PATCH v1 1/2] dt-bindings: spi: add " Yinbo Zhu
2023-03-08 11:30 ` Krzysztof Kozlowski
2023-03-09 2:08 ` zhuyinbo
2023-03-09 6:23 ` Krzysztof Kozlowski
2023-03-09 7:22 ` zhuyinbo
2023-03-13 2:09 ` zhuyinbo
2023-03-13 6:42 ` Krzysztof Kozlowski
2023-03-08 14:06 ` Rob Herring
2023-03-10 2:31 ` zhuyinbo
2023-03-10 9:08 ` Krzysztof Kozlowski [this message]
2023-03-10 9:33 ` zhuyinbo
2023-03-08 2:59 ` [PATCH v1 2/2] spi: loongson: add bus driver for the loongson spi controller Yinbo Zhu
2023-03-08 15:03 ` Mark Brown
2023-03-10 10:01 ` zhuyinbo
2023-03-10 12:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c254b2f1-2086-498f-35c6-c87d838bcb2d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®