From: Johannes Berg <johannes@sipsolutions.net>
To: Wentao Liang <vulab@iscas.ac.cn>,
miriam.rachel.korenblit@intel.com, kvalo@kernel.org
Cc: emmanuel.grumbach@intel.com, golan.ben.ami@intel.com,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 RESEND] wifi: iwlwifi: mvm: Add error logging for iwl_finish_nic_init()
Date: Tue, 22 Apr 2025 09:34:31 +0200 [thread overview]
Message-ID: <c254c3df09fd2c3318f614e76187781be88c6030.camel@sipsolutions.net> (raw)
In-Reply-To: <20250422023234.1992-1-vulab@iscas.ac.cn>
On Tue, 2025-04-22 at 10:32 +0800, Wentao Liang wrote:
> The function iwl_pci_resume() calls the function iwl_finish_nic_init(),
> but does not check their return values.
>
> Log a detailed error message with the error code to aid in diagnosing
> root causes if encountering irreparable errors. While this does not fix
> the underlying problem, it assist debugging by making the failure
> visible in logs.
>
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> v2: Fix improper code.
>
Did you though? Especially before _resending_ (whilst a lot of the world
has holidays/vacations too...) you could check patchwork maybe?
Actually, just don't resend unless you see that it's no longer handled
in patchwork?
johannes
next prev parent reply other threads:[~2025-04-22 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 2:32 Wentao Liang
2025-04-22 7:34 ` Johannes Berg [this message]
2025-04-22 12:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c254c3df09fd2c3318f614e76187781be88c6030.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=golan.ben.ami@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®