mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Miaoqian Lin <linmq006@gmail.com>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Stephen Boyd <swboyd@chromium.org>,
	David Heidelberg <david@ixit.cz>,
	Guo Zhengkui <guozhengkui@vivo.com>, Xu Wang <vulab@iscas.ac.cn>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Rob Herring <robh@kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>,
	<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf
Date: Tue, 14 Jun 2022 09:31:15 -0700	[thread overview]
Message-ID: <c258b072-82cf-71a8-fdfb-79df52c5d480@quicinc.com> (raw)
In-Reply-To: <10ac04f9-6374-0f85-166c-223a220a8c0d@linaro.org>



On 6/14/2022 3:09 AM, Dmitry Baryshkov wrote:
> On 14/06/2022 13:07, Miaoqian Lin wrote:
>> Hi, Abhinav
>>
>> On 2022/6/11 7:20, Abhinav Kumar wrote:
>>>
>>>
>>> On 6/7/2022 4:08 AM, Miaoqian Lin wrote:
>>>> of_graph_get_remote_node() returns remote device node pointer with
>>>> refcount incremented, we should use of_node_put() on it
>>>> when not need anymore.
>>>> Add missing of_node_put() to avoid refcount leak.
>>>>
>>>> Fixes: 86418f90a4c1 ("drm: convert drivers to use 
>>>> of_graph_get_remote_node")
>>>> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>>>> ---
>>>>    drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>
>>> This patch itself looks fine and will cover the cases when there was 
>>> an error and we did not release the refcount.
>>>
>>> But, even in the normal cases I am not finding where we are releasing 
>>> the refcount for the panel_node.
>>>
>>> I dont see a of_node_put() on mdp4_lcdc_encoder->panel_node.
>>>
>> Thanks for your review.
>>
>> I don't see it either. It's a bit messy because the reference assigned 
>> to mdp4_lcdc_encoder->panel_node and mdp4_lvds_connector->panel_node 
>> both.
> 
> I have a plan to rework mdp4 lcdc support once I get my ifc6410 lvds 
> cable. Thus I think we can land this patch now and fix the mdp4 
> lcdc/lvds code leaking the reference in the due time.
> 

Alright, with that assurance,

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>

Will pick it up for -fixes.
>>
>>> Am i missing something?
>>>
>>>> diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c 
>>>> b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>>>> index fb48c8c19ec3..17cb1fc78379 100644
>>>> --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>>>> +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c
>>>> @@ -216,6 +216,7 @@ static int mdp4_modeset_init_intf(struct 
>>>> mdp4_kms *mdp4_kms,
>>>>            encoder = mdp4_lcdc_encoder_init(dev, panel_node);
>>>>            if (IS_ERR(encoder)) {
>>>>                DRM_DEV_ERROR(dev->dev, "failed to construct LCDC 
>>>> encoder\n");
>>>> +            of_node_put(panel_node);
>>>>                return PTR_ERR(encoder);
>>>>            }
>>>>    @@ -225,6 +226,7 @@ static int mdp4_modeset_init_intf(struct 
>>>> mdp4_kms *mdp4_kms,
>>>>            connector = mdp4_lvds_connector_init(dev, panel_node, 
>>>> encoder);
>>>>            if (IS_ERR(connector)) {
>>>>                DRM_DEV_ERROR(dev->dev, "failed to initialize LVDS 
>>>> connector\n");
>>>> +            of_node_put(panel_node);
>>>>                return PTR_ERR(connector);
>>>>            }
> 
> 

      reply	other threads:[~2022-06-14 16:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 11:08 Miaoqian Lin
2022-06-07 15:39 ` Dmitry Baryshkov
2022-06-08 22:14 ` Stephen Boyd
2022-06-10 23:20 ` Abhinav Kumar
2022-06-14 10:07   ` Miaoqian Lin
2022-06-14 10:09     ` Dmitry Baryshkov
2022-06-14 16:31       ` Abhinav Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c258b072-82cf-71a8-fdfb-79df52c5d480@quicinc.com \
    --to=quic_abhinavk@quicinc.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=david@ixit.cz \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=guozhengkui@vivo.com \
    --cc=linmq006@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=robdclark@gmail.com \
    --cc=robh@kernel.org \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®