From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752311AbdJ0KQT (ORCPT <rfc822;w@1wt.eu>);
        Fri, 27 Oct 2017 06:16:19 -0400
Received: from mout.web.de ([217.72.192.78]:50823 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752016AbdJ0KQR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Oct 2017 06:16:17 -0400
Subject: Re: iio/accel/stk8312: Improve unlocking of a mutex in two functions
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Hans de Goede <hdegoede@redhat.com>, Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <ae9d7e7f-541e-ce0c-1d41-6b9793c98f78@users.sourceforge.net>
 <20171026170913.5ff10718@archlinux>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <c2620449-b80a-f0ef-c0d2-92d0c7fb4906@users.sourceforge.net>
Date: Fri, 27 Oct 2017 12:15:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171026170913.5ff10718@archlinux>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:aj89wUTm3zSz5L1Tfa5tRIbFkCENBwH9oxdPHf5O4ddypRM7vFm
 xlWbuDaFOrjF8+fFCdJnJma+o78dwCyUbiDQr8AJG48SI6/51SU+KVTpT38zuau4T0FG6zd
 iYakLZdqJJ0z12htCh1im56Z0V+cK1NG8DHO9pituVpwBGJoxC9xErD9gBPaxPETyjmBkN8
 9qw1tcMYDk1/EYP3T4/iA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:7PGLtwuzDcE=:J+yexOUqD+XVLPHMU4LuSj
 kaIpfLcrUgxfKKYfV+ZW5/P0G8pI3aOSdEl1fp+NoMaVck8mPKrcwJfkoMEZC9BiD8EYknN+t
 s2LB1XWQvAKgYcovaxAWBGDKf9qjscKYZAdtAj6vTlytpkUdbSsqOAezwaID1GxcIcm6qwZf3
 UtjmJ8h8iw9Z/Jka9aZ1McJTEfYqmeH+lica3PHCzfNX0kFdYhfV1aDnjyWnlPFEwaWWMi9Qk
 mr64IiHsc7/hgZkrVDhs57spF1+gvgChs3p7xuP6kRQEC/fJGj37V3tO/XWj2dr1DxO5SbUed
 yg3ghWscgFrw7yAzJaJk+ymb6i4W9vSbnav4Ufx2W3PDbGkAab10gPS3NL1qZoPxiP0+eXQtL
 ltni3I6Bp292V3VcMCSjJ6EL8FXT5KYPzNLIORIYsfzSp6yg+00DJHP1HhL2BnedRq1U951cn
 6uqf2K0CWinhljOzbn28LWjltPBJt2F6TDO+vXoq7sRORPINML6EiGdxjqtDkablaGHBePy7i
 tFfGk+h+2A2xTQYgzOd+uV9NzzBZ/7tN7KGP2AdvVMbUUA6UDDZtgVzZK0fP0qfasFZgyHAyd
 9p0bPakVaIJKD0Qkb+6wZ8du8asxu21M6u6ZOhrc8SeAAYWv1x8qgvsBhwsdciBKShTRVq/Wa
 sAYqDokgdad52hU5xPhwjW6XP3XS0u+hH0RO9Jjg26hKS4mM9pcAl367l/tvJQoSKMU4SwHxK
 Dx9IxtK0EcfWv6RxCJlvTDbhO87qZF5xI0oWm5a3cSZGFJDb38SqexIV+CBoFN1fJfVL+Tnes
 kG7LADBPPtmplCOm47lZcNCQ3Tm5TT7vJQYwAKeSWpBWJvU8j8=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> In the second case, the jump backwards just makes the code harder
> to read than it currently is.

Maybe …

But I proposed an other source code layout for useful reasons.


> There is no firm rule about error handling in one place.

There are some design options available.


> If it leads to more complex flow as here, don't do it.

I would appreciate to clarify such a view a bit more.
How would you like to achieve a complete and efficient
exception handling in shown places?

Regards,
Markus