From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E963E3A962D for ; Thu, 30 Apr 2026 10:49:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777546182; cv=none; b=mwLq3kz4RlPmQvfNrscsp6W5BwtKdvyhEAcwcOF/E6bI3kwHuch83arV7g6e9ZGf6juhC9PGDPmtWs79JWS2NxtugpPrGt+mPH4ZfpooxIb2Sc5BBZxTkRywwfpoKlXkFowA3s6DL3Gp5/EjcAnkZJzdqhY5dmM9lrh0MIacqWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777546182; c=relaxed/simple; bh=9ExJAewyRTdinJlKoHCm99hH0XRD1SnaeObHp3MJn4I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VW9n2GbKXgo4AtIo3XngNzR57sD7SbdCHQqmG3s0M5DDL6cD3pkOZqLCxMYvptGv8yVoo1S3aUVH4vgnJTqYpiMB2RzY4h29em/rBTL02nHqfk81uqaWwEkGUg7sYkQLj2PCspprPnqJy8rgsUsAfC4LYYnJM8xJ52cRaaU5s8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bbInM4mY; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bbInM4mY" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5a2c0615d6fso96872e87.2 for ; Thu, 30 Apr 2026 03:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777546178; x=1778150978; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=cmyJ53pHqLwHEKIa38JSRjFXiWvFtp6uO7lzOz7NoBI=; b=bbInM4mYXpXSlFbqXBUU3X8qqVzl8+dJpt/BFx2kMGgmLEQdMEH0knopdaJuWXg0DI G7MADJp7xROGpLhRqw5FaopA5SHjL6C73KNAPaMfdv3+C3Wo9VcD4h0XenV2toM1abT9 wPyv7qECTGe71Qi8OEjzRMQ0nbAuTLxexwDKsJacelJ6U6JYQDiPH0CrbRzuIOLm37q7 wPwsFtf3Ur9ej9UAlGbFZk1hhvqzJJ7jjpEY7R2buCt5cHK8DB9/4//4DRxP2jjzV5Hc rJYvieZE8pz/nWAkRDehm/oyW7E6cMK8EMnClkr+d8paBrYlpcupOZwLPUQ6trVBkPN0 Pz1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777546178; x=1778150978; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cmyJ53pHqLwHEKIa38JSRjFXiWvFtp6uO7lzOz7NoBI=; b=RbZ/s/lAGAg06VOAJ9DOSvFgv+cPBnLv2LiW2R/mZf8J00gNy6QFAxYnqBIgTSjEDY GweKbttPWjb65QehIxulnwAcY4M94vnkNcnFLhs1GLfl68ULO4v0VH8K6xOHA+X5XDEd RU5xlhFyLlDhE/yCOrG09cctd+RF5ODXoH64ipVoo6I/75DiK9yl+iL/mJGhPZqFJjz9 kwx8fon+waLCfpCMWFA3wij4X5Gakbbfl8cyu7E4gn5rS8Y3XVbbSw73YRIXfR8h4zQI iMS8R4lPHHoLqbulvg4fuiLCKeM9IthkuF6Tjl9RRyLyPJ2sC3LdBoil1jQUSx8PL4Br ehfg== X-Forwarded-Encrypted: i=1; AFNElJ8BeK2rAgZWQAhwV7vwusLh7+WoAi+lrB+f120n1Ih1Xa5RX4boO18nIKuQbCdwTBbtkxcm/S4wXgQn2jY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx7ueSBJ4GcNALppXjG7htG1Pzo0MwsZoFs/+mxZMFnVJeuUWT 5y4gerAFtsYAp0JGjeofkB6/hX+yGkhSpd35BJUR2sa13cxEI9nRELJLeR6Rmr9VyuU= X-Gm-Gg: AeBDieshYwbt9Vfgoh1WdXOihxEu37Dn4djuVhH62QCSrUGUBcdstiW/oSwYUvh+MGV 3MCC4sWmqG6c8qjXBK17+AfxaESkdCBz+t3Zr99DTigRDJZBaCSDCKCgBpWmj1lRNfoDGABigl/ MtxefKZkgyeRUnScwg3Qc3YjOaBxrl1stKZMOFoNYcEtlECEreS12xMgUGrxT0Mqg36V3GOVuQD 0OM6vTXCmyfjAv6z9Em0RDD7rD/2c6xcVidu0LYVntrt0XzDALf71KMfwbUpKloXlBBUzWJC/nj UTyOz4QGkI3110o7XzgGUOGPnWqusgPVLrmQth0j3a8VzW/IZnAFA/llaO9chfrsXnfYDbDGCK5 IdpgWPlIgNUePQZXgvlNMPYLV6N1HC10fXFevpY2yYmqp8eUafAxO9g/M9TtTWh1ao340umahkg dSg7scJgeC6OReIZvjZ4Zfbk7ee3uJ3O20arNx8LFblZ3Zq2XRuXa8y2ZgkghMbaPOhDyJFYFRc lmWM8lHQCQ7BAX7 X-Received: by 2002:a05:6512:10d6:b0:5a4:1977:dcfe with SMTP id 2adb3069b0e04-5a8522acbdcmr330857e87.2.1777546177941; Thu, 30 Apr 2026 03:49:37 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3934f9c15e5sm4763751fa.11.2026.04.30.03.49.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 03:49:37 -0700 (PDT) Message-ID: Date: Thu, 30 Apr 2026 13:49:25 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: sc8280xp: gaokun3: add front camera sensor node To: Pengyu Luo , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Martin Kepplinger-Novakovic , Sakari Ailus , Mauro Carvalho Chehab , Hans Verkuil , Martin Kepplinger Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20260425105300.745044-1-mitltlatltl@gmail.com> <20260425105300.745044-4-mitltlatltl@gmail.com> From: Vladimir Zapolskiy In-Reply-To: <20260425105300.745044-4-mitltlatltl@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/25/26 13:52, Pengyu Luo wrote: > Hi846 is found on my Gaokun3, descripting it. To the best of my knowledege there is no 'descripting' word. Say it simpler like Describe Hi846 camera sensor found on Gaokun3. > > Note that it seems that only Goakun3(3.0GHz) version is equipped with > Hi846. Goakun3(2.69GHz) version is equipped with S5K4H7. > > Signed-off-by: Pengyu Luo > --- > .../boot/dts/qcom/sc8280xp-huawei-gaokun3.dts | 128 ++++++++++++++++++ > 1 file changed, 128 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts b/arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts > index 9819454abe13..39e559e91289 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -27,6 +28,7 @@ / { > compatible = "huawei,gaokun3", "qcom,sc8280xp"; > > aliases { > + i2c2 = &cci2_i2c1; I don't think that it makes big sense to add this I2C alias, please consider to remove it. > i2c4 = &i2c4; > i2c15 = &i2c15; > serial1 = &uart2; > @@ -47,6 +49,21 @@ framebuffer0: framebuffer@c6200000 { > }; > }; > > + leds { > + compatible = "gpio-leds"; > + > + pinctrl-0 = <&cam_indicator_en>; > + pinctrl-names = "default"; > + > + privacy_led: privacy-led { > + function = LED_FUNCTION_INDICATOR; > + color = ; > + gpios = <&tlmm 34 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + panic-indicator; > + }; > + }; > + > wcd938x: audio-codec { > compatible = "qcom,wcd9380-codec"; > > @@ -98,6 +115,20 @@ switch-mode { > }; > }; > > + vreg_camf_1p2: regulator-camf-1p2 { > + compatible = "regulator-fixed"; > + > + regulator-name = "vreg_camf_1p2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + > + gpio = <&tlmm 44 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-0 = <&camf_1p2_reg_en>; > + pinctrl-names = "default"; > + }; > + > vreg_misc_3p3: regulator-misc-3p3 { > compatible = "regulator-fixed"; > > @@ -462,6 +493,13 @@ vreg_l8c: ldo8 { > RPMH_REGULATOR_MODE_HPM>; > }; > > + vreg_l11c: ldo11 { > + regulator-name = "vreg_l11c"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + regulator-initial-mode = ; > + }; > + > vreg_l12c: ldo12 { > regulator-name = "vreg_l12c"; > regulator-min-microvolt = <1800000>; > @@ -577,6 +615,66 @@ vreg_l10d: ldo10 { > }; > }; > > +&camss { > + vdda-phy-supply = <&vreg_l6b>; > + vdda-pll-supply = <&vreg_l3b>; > + > + status = "okay"; > + > + ports { > + port@3 { > + csiphy3_ep: endpoint@0 { > + reg = <0>; > + > + clock-lanes = <7>; Please remove 'clock-lanes' property from above. > + data-lanes = <0 1 2 3>; > + remote-endpoint = <&hi846_ep>; > + }; > + }; > + }; > +}; > + > +&cci2 { > + status = "okay"; > +}; > + > +&cci2_i2c1 { > + /* On Goakun3(2.69GHz), S5K4H7@2d, image quality is better than hi846 */ > + camera_front: camera@20 { 'camera_front' label is unused and should be removed. > + compatible = "hynix,hi846"; > + reg = <0x20>; > + > + pinctrl-0 = <&camf_rgb_default>; > + pinctrl-names = "default"; > + > + clocks = <&camcc CAMCC_MCLK3_CLK>; > + > + assigned-clocks = <&camcc CAMCC_MCLK3_CLK>; > + assigned-clock-rates = <24000000>; > + > + reset-gpios = <&tlmm 15 GPIO_ACTIVE_LOW>; > + vddio-supply = <&vreg_l2c>; > + vdda-supply = <&vreg_l11c>; > + vddd-supply = <&vreg_camf_1p2>; > + > + leds = <&privacy_led>; > + led-names = "privacy"; > + > + orientation = <0>; /* Front facing */ > + rotation = <0>; Both properties above can be removed as the default ones. > + > + port { > + hi846_ep: endpoint { > + data-lanes = <1 2 3 4>; > + link-frequencies = /bits/ 64 <80000000 144000000 200000000 288000000>; > + remote-endpoint = <&csiphy3_ep>; > + }; > + }; > + }; > + > + /* actuator???@58, Goakun3(2.69GHz) only, eeprom@50 */ > +}; > + > &dispcc0 { > status = "okay"; > }; > @@ -1318,6 +1416,36 @@ hstp-sw-ctrl-pins { > }; > }; > > + cam_indicator_en: cam-indicator-en-state { > + pins = "gpio34"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + camf_1p2_reg_en: camf-1p2-reg-en-state { > + pins = "gpio44"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + camf_rgb_default: camf-rgb-default-state { > + mclk-pins { > + pins = "gpio17"; > + function = "cam_mclk"; > + drive-strength = <6>; > + bias-disable; > + }; cam_mclk pad function descriptions on all 8 pads supporting this function shall be added to the platform in a separate commit to sc8280xp.dtsi > + > + sc-rgb-xshut-n-pins { > + pins = "gpio15"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + }; > + > i2c4_default: i2c4-default-state { > pins = "gpio171", "gpio172"; > function = "qup4"; -- Best wishes, Vladimir