From: Joe Perches <joe@perches.com>
To: Markus Elfring <Markus.Elfring@web.de>,
kernel-janitors@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] openpromfs: Adjust three seq_printf() calls in property_show()
Date: Tue, 02 Jul 2019 09:08:04 -0700 [thread overview]
Message-ID: <c26343465261e636ef029b8d0d7cb46183a23d23.camel@perches.com> (raw)
In-Reply-To: <22563348-fefa-8540-9d71-de37764f0596@web.de>
On Tue, 2019-07-02 at 17:40 +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 Jul 2019 17:24:27 +0200
>
> A bit of information should be put into a sequence.
> Thus improve the execution speed for this data output by better usage
> of corresponding functions.
>
> This issue was detected by using the Coccinelle software.
(wasn't Markus perma-banned?)
> diff --git a/fs/openpromfs/inode.c b/fs/openpromfs/inode.c
[]
> @@ -76,14 +76,14 @@ static int property_show(struct seq_file *f, void *v)
> while (len > 0) {
> int n = strlen(pval);
>
> - seq_printf(f, "%s", (char *) pval);
> + seq_puts(f, (char *) pval);
>
> /* Skip over the NULL byte too. */
> pval += n + 1;
> len -= n + 1;
>
> if (len > 0)
> - seq_printf(f, " + ");
> + seq_puts(f, " + ");
> }
> } else {
> if (len & 3) {
> @@ -111,8 +111,7 @@ static int property_show(struct seq_file *f, void *v)
> }
> }
> }
> - seq_printf(f, "\n");
> -
> + seq_putc(f, '\n');
> return 0;
> }
If this is really useful (and it's really not),
at least change void *pval to char *pval and
remove a bunch of useless casts.
next prev parent reply other threads:[~2019-07-02 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 15:40 Markus Elfring
2019-07-02 16:08 ` Joe Perches [this message]
2019-07-02 17:59 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c26343465261e636ef029b8d0d7cb46183a23d23.camel@perches.com \
--to=joe@perches.com \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®