From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE77425784E for ; Tue, 28 Oct 2025 19:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761679103; cv=none; b=qWnVUhVNLjCP5PxEZpcvcSrZ5G7CuFXyNxoM5ZaloM3Uguli/etGCIBPqDsMbE8yG3VQyhWn7h+piQe2JK8lgA/vu4lxqsaVJw3RURuy/XqSTPWGPNFdzB3a8Jl229xBL49/SYBUFiSfdDK5L3UR6H2Ow8GSzQtN0SjG9GPd41I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761679103; c=relaxed/simple; bh=0hhlCwxtrTuVy9ywy8PZ04TLMeWmNoQW1VuNCe9Lhnc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LZ2u3KjqOjSUqiduarYWpRaXv//dTdyE4tRknMxJnbwAr5cdwIPm+8ByaLmmzDs/Gi8tiysNIJYEowTh3MILDhwi3YOjY4q+RkUBirbiWSbQDuqyXQSxBZbTo0XEgkLoSzDchLiTcM5LIl4pzRnCx7AbnAoj3qEpvr1JGzKjgDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Qo3Ag8i3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QG/+FyPk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Qo3Ag8i3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QG/+FyPk" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59SEoId71916412 for ; Tue, 28 Oct 2025 19:18:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cE6kvUJtutSNKY0OcaTxxOhxbbMxO1uEYLUzt+x1AGw=; b=Qo3Ag8i3WEdvawyt NceclgyZWGnUROoX+denb7Xm6kAQytPtpD/uxRZ73cnbLYHRF2oCqcfXeL3PtkSa eEk1sGctW5envpKDehgT0XcQskIPf7lg7Eh6IUT10/xK7diITsF8YyGIGyfFCE6e KulelTE+FNOym+MPN1HwHnuCCaPf1sWUoOMAWztPOozmTQvmr6f3fKzSE8xnDFFG fYvA03BfEG61SE8LiL7DZ8PubSYphrSXwNBgdNe8IuP6FKao5VhWkW8+KCfaJ3vo BhBSTOqjsEKO3eW84oj94icChInxUNoiMHBdkuMoxy+7zBU1nVAuKU5LgjfAvV1U qSjojg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a2g2fupab-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Oct 2025 19:18:21 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-290c9724deeso56971805ad.2 for ; Tue, 28 Oct 2025 12:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761679100; x=1762283900; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cE6kvUJtutSNKY0OcaTxxOhxbbMxO1uEYLUzt+x1AGw=; b=QG/+FyPki0zWQtzhKTVq2jrL1iOLEAYcw8vpkAApWE1a2KVVDvM9KcgUWILZlU7HyG vitttkwIl3tFg+38o7MnMJ1teunPAXonY0Ej1Eq86RqZo92SpwrduewaE7xZEEAkesdH O7DKa3mmHosXaALD1Y15S1TtSIYcao0V0OnwOd6fy5Yg/CyhpH+JZieLATDpedPDUnV7 CBx0LxkKs5dR6znc90Ua262ybk9bboF688FIu9Tu4gnwcEQbwnuf2AvVkfc3JbrQShpu 4ww2+JnjGN/XRKN6fKKSessdE3F1M569b7oyYqGrbwyV6khkHH6dSqzSD7VEIGUV22Xr wNnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761679100; x=1762283900; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cE6kvUJtutSNKY0OcaTxxOhxbbMxO1uEYLUzt+x1AGw=; b=o27MMDfbk5j+piyDnp2R4Zlj/ye4HsiaH9Req8jfKOhpwWSM9ArBe08K5o56qO+OVj b5nhhFY9Gj4oU3tN+pA/Kz1ypbGQsyJL3jlDZoltXpaa8QM1Bfo+0eCx3gRuGl6XvnE4 4Ec13uxfDAu5N/WJMmikgLbi+H5a8tO/5Z9E1zbWAQ9WVUgD2eycIKhFQQL0sR0YDyTY lx2ERWf3GyMEKYoJ/UipXQVh92NQgWQU+rKsoYcFQ+YS/zZ8stYjM3Q3i09fpOjhDhF/ cZxCL2m/xPY6Ea/2axNuicFdlRuaNHDiEq9M4CsFdm8hb6j7x+kyMz4hAr9Xl4P911gn KQpA== X-Forwarded-Encrypted: i=1; AJvYcCVMZYduJrPZyS/L6igf+6iB7+SK00Im4LVKcMhULCJSKVHblF7z0eNM1Go/M8B6fucu8bKpylfLn7o2eXc=@vger.kernel.org X-Gm-Message-State: AOJu0YyP3FXxDhiBTdiya6C6icnNB2af4J7KRXC+o0OgROOZ2XYzZnFB nSqYIBnT9L77BulaUT4XwGw4swy52C1LrEozXwxb6AcRTtXe3F0MKevkY2r0g5j95ZtZaVOwupq OSyXJ45Oqi4KeEsdbavhIbaqQ3kJ0JNZzaqC1I3ddRzRbYARcKJkg3V6U53a0H06DSLY= X-Gm-Gg: ASbGncuCpNVRMoS2iVQXbPz7PIt+DCzDN5WxgFWRFE2VGXVjd5UhmB+1mqakXSXpoMD nCRbC4Ws9g+cl3Cr6HubmmTwFuuw9C+DRrnF9g6HyHFdN/EWJ80z+vePBBrJbq8yA2UEIm4zEND RE2fnUniv4qr8w0IanVkblhotc7FF42MhniOUNRUoQEOz10FlDOtwWx4ioHmcfaqoH5dxvq+luu 6ArOq6hL+IDsotkLGvOT+YRYoHz0FS9dzDIveW/wRlGb678Y2b8CDgikg+w9PBs/RMnuUBHACQk T48wlnm5mP+ueolZjsW3YsTipCKIC+4+KzqdSm2cGtBwBdmPCEQTLD3f0lidOJJUuwsz+QJUomU 6cKUCGI1PAN2DuTRRCvGa1JyziHbt4Hn0/qGYz4ryyHCK2CF1/oJ+PA== X-Received: by 2002:a17:903:2a85:b0:269:b2e5:ee48 with SMTP id d9443c01a7336-294def62ea6mr2685645ad.52.1761679100190; Tue, 28 Oct 2025 12:18:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiS4DA5cZRIsPNZiUXqoc8KRQ897PBaD+pMPM1dqIN+3BfFWkz5CMP9zUSwsQqIiqDj9LO5w== X-Received: by 2002:a17:903:2a85:b0:269:b2e5:ee48 with SMTP id d9443c01a7336-294def62ea6mr2685185ad.52.1761679099527; Tue, 28 Oct 2025 12:18:19 -0700 (PDT) Received: from [10.62.37.19] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498cf49easm126964705ad.9.2025.10.28.12.18.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Oct 2025 12:18:18 -0700 (PDT) Message-ID: Date: Tue, 28 Oct 2025 12:18:17 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding To: Krzysztof Kozlowski , Hangxiang Ma Cc: Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Bryan O'Donoghue , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251023-add-support-for-camss-on-kaanapali-v3-0-02abc9a107bf@oss.qualcomm.com> <20251023-add-support-for-camss-on-kaanapali-v3-2-02abc9a107bf@oss.qualcomm.com> <20251028-wonderful-olive-muskox-77f98d@kuoka> <7efc63ed-9c84-43c0-b524-f7e9e60b2846@kernel.org> <0ddf3634-d9eb-425a-b35b-c0b4ee995a4b@kernel.org> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: <0ddf3634-d9eb-425a-b35b-c0b4ee995a4b@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI4MDE2MiBTYWx0ZWRfX3+sFybbhwaPe 6IThEGXekkn7HU+YnGrZVz5ecX8CIGiNDwQcZR063kJ6LvnKmWH9f/Ow8PGCtOqEmGPXFKCbySp EhDfX//A5Htry48RyyQBbeQJwpYzvxw35qOd5Jg1a1hUeON4bErLIC93IlJPcowOrtICkC/1UK0 u/H5qD0gx2aUnJhlp+UTediKbL+bXl6Al0LguZgMN+fUEptOXMWqqxVZPxz/3hDEhKsXnW93/0R oW8ZgCahkZ4JkpsZ+oVKCLFNnIydD5yfq3WKLsbjJOn0raaYTvINNbCNwJ1m0I46N1FoRU94mAY H8jFXU8GqNpC/hdNgPBQgcB0S21S+rJP/+tVCrD+AhLpG/IFKfMj/bSeMBwXakUeIykrZGRGKRv +ejOGkyDkr1g9b7PtGafN+DY5v56aw== X-Proofpoint-ORIG-GUID: z95zzDpVWDFqXYcka0LOmmUL0KNBdDyz X-Proofpoint-GUID: z95zzDpVWDFqXYcka0LOmmUL0KNBdDyz X-Authority-Analysis: v=2.4 cv=FIMWBuos c=1 sm=1 tr=0 ts=690116fd cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=I-EcnzrSYEg_xlsmLtMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-28_07,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510020000 definitions=main-2510280162 On 10/28/2025 11:39 AM, Krzysztof Kozlowski wrote: > On 28/10/2025 18:45, Vijay Kumar Tumati wrote: >>>>>> + - const: tfe1 >>>>>> + - const: tfe2 >>>>> Why not using the same names as before? It really does not matter that >>>>> it is thin or image, all of them are the same because only the >>>>> difference against top matters. >>>> Right, this is done to maintain the consistency with the clock driver on >>> Sorry, this makes no sense. This device has nothing to do with clock >>> driver. Don't ever use clock drivers as arguments for doing something in >>> completely different place. >>> >>> Not mentioning that drivers don't matter much for the bindings, so I >>> really do not get what you try to explain here. >> Understood. I meant to say that it is consistent with the naming for the >> TFE device that is available on Kaanapali. If our intention is to keep >> the names in the bindings same as previous generations despite the >> changing HW architectures, we could change these to IFEs, to be >> consistent with previous  generations. Please advise. Appreciate your >> inputs here. > > You name these based on the provider, the clock controller or whatever > controller, and that's the mistake. Names are coming from this device > point of view, from the consumer. This device does not care whether this > is Thin or Image or Whatever GDSC. > > > Best regards, > Krzysztof Gotcha. Thanks for the explanation, Krzysztof. Agree with you, we are just trying to differentiate the GDSCs / power domains for TOP and to each of the front end modules, to control them independently based on the usage, as we have one common device 'camss' in the DT. Looking at this device as a whole (as a consumer), it has one TOP GDSC and one GDSC to each of the TFEs (the front end device itself in this architecture is called TFE) separately for clock gating. TFE_0_GDSC is enabled only when TFE0 is used, for instance. That way it seemed fitting too. But if that's not OK, we have two options. One, we change this to "ife" to be consistent with previous targets or the second, use even more superficial name like "xfe_0", "xfe_1"etc. for power domain names that represent any front end (thin or otherwise, which like you said doesn't matter here) and can be adopted to all future targets. Please let us know your thoughts. Thank you very much.