mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Marco Crivellari <marco.crivellari@suse.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Michal Hocko <mhocko@suse.com>
Subject: RE: [PATCH 1/2] wifi: rtlwifi: add WQ_PERCPU to alloc_workqueue users
Date: Tue, 18 Nov 2025 00:41:09 +0000	[thread overview]
Message-ID: <c27c755c188f48e8b2ab60868b0e0173@realtek.com> (raw)
In-Reply-To: <CAAofZF4RK7Dt=eJAXjn0Nbmw4rR_RJ4Nc4P3LkmRDCE_dvK6dQ@mail.gmail.com>

Marco Crivellari <marco.crivellari@suse.com> wrote:
> Hi,
> 
> On Mon, Nov 17, 2025 at 1:53 AM Ping-Ke Shih <pkshih@realtek.com> wrote:
> > [...]
> >
> > I think this driver should use WQ_UNBOUND as well as another patch in this
> > patchset.
> >
> >
> > I feel most user scenarios should be WQ_UNBOUND. Could you share which case
> > uses WQ_PERCPU?
> 
> I think a typical scenario is when per-cpu variables are used.
> But this is not the case here, for both the patches.
> 
> So yes, unless there is the need to have the item scheduled on the same CPU,
> this can be converted to WQ_UNBOUND.
> 
> I did the same for other series in other subsystems. If you want, I
> can send the v2
> with the change.

Please send v2 with WQ_UNBOUND. Thanks.


  reply	other threads:[~2025-11-18  0:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 16:06 [PATCH 0/2] add WQ_PERCPU to alloc_workqueue Marco Crivellari
2025-11-13 16:06 ` [PATCH 1/2] wifi: rtlwifi: add WQ_PERCPU to alloc_workqueue users Marco Crivellari
2025-11-17  0:52   ` Ping-Ke Shih
2025-11-17 10:02     ` Marco Crivellari
2025-11-18  0:41       ` Ping-Ke Shih [this message]
2025-11-18  9:26         ` Marco Crivellari
2025-11-13 16:06 ` [PATCH 2/2] wifi: rtw88: " Marco Crivellari
2026-01-22  1:29   ` Ping-Ke Shih
2026-01-22  8:59     ` Marco Crivellari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c27c755c188f48e8b2ab60868b0e0173@realtek.com \
    --to=pkshih@realtek.com \
    --cc=bigeasy@linutronix.de \
    --cc=frederic@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    --cc=mhocko@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®