From: Markus Elfring <Markus.Elfring@web.de>
To: Charles Han <hanchunchao@inspur.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Stanley Chang <stanley_chang@realtek.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: realtek: fix NULL deref check in extcon_rtk_type_c_probe
Date: Mon, 18 Nov 2024 13:00:09 +0100 [thread overview]
Message-ID: <c27f53e8-5155-47f6-afb7-15b53cd5aa4d@web.de> (raw)
In-Reply-To: <20241025094650.253599-1-hanchunchao@inspur.com>
> In extcon_rtk_type_c_probe() devm_kzalloc() may return NULL but this
> returned value is not checked.
Another wording suggestion:
A devm_kzalloc() call can return a null pointer on failure.
But such a return value was not checked in this function implementation.
Thus add a corresponding check so that a null pointer dereference
will be avoided.
Would a summary phrase like “Prevent null pointer dereference in extcon_rtk_type_c_probe()”
be a bit nicer?
Regards,
Markus
next prev parent reply other threads:[~2024-11-18 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 9:46 Charles Han
2024-11-18 12:00 ` Markus Elfring [this message]
2024-12-08 12:45 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c27f53e8-5155-47f6-afb7-15b53cd5aa4d@web.de \
--to=markus.elfring@web.de \
--cc=cw00.choi@samsung.com \
--cc=hanchunchao@inspur.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=stanley_chang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®