From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61EC21DF27F for ; Tue, 17 Feb 2026 13:28:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771334907; cv=none; b=qI/zDLE4/5s7CHzoq5ZVLcy7MUsZvIZOmNNvWxKhzLpEkY1mAv05c7Rod0ge1GB6i9qBHNogcdHKrs1ZuhZ0yzXy4+9eSKyOv4dYFtcaR22Exzev0H6Zz+cU3UeWTTIrcWMLBXSB4un6Uc4LWSpj8EYTIi1Gp4wIn94NKYo+eGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771334907; c=relaxed/simple; bh=cFF52qz0PD8aczZoib1i23aZ9w/Zx2t4N+NgXu2ufjg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=lrAMrha9me3mkmD12vwnvrPRQhfcx0OKia69olQXdr3FlVciYSQ72ZKjxrq5ch4HqnB65Lmrmul7vTzW2hozKvsCHY9wUaVnxa11JYjfS4Tj3vWlXpBuVMQm1SoS25kSSZHWr/3FIJyfmgYDZLKwjTm6JLZCyPYMv3mlkfNWGqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EqqNDseO; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EqqNDseO" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-4362c635319so4188078f8f.2 for ; Tue, 17 Feb 2026 05:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771334905; x=1771939705; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=aOWNrVRUU5sVLN+DLhuo4oI/n0WRUiVr3FUn821tZYo=; b=EqqNDseOQRY/8PIsZ2uk9PE3Jp0ec5+fckOJ/kwiuJSwstzO8+adW3HBv36ZFCwUaL Wxw0QrFUGvhU2yojXFlVpmXoDr6WLoaLdOcd391AfVBhYGufepZHD6DNhxW07daA0f+p G8qYV+u91AvQMBGaRjcejeGqY90ITUFv7mRO5tLReGy/PsUcDGTkH6/KiMALtZe6Ch8J d9b7MsTGea09eawJX8WdDDth9cD9d/ZuLrZtHZLvCOSTtFZhfW9az6Sg6BtAr/nVY1iR d3UU4TJ0qk3YseKVk15ySt7bmuqsP0xEhZ4AWzQ0Ej+JAJyybFtn0AqnTbFqgGzYGOuS qqaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771334905; x=1771939705; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aOWNrVRUU5sVLN+DLhuo4oI/n0WRUiVr3FUn821tZYo=; b=GCUfRe+VO1/aoG0ZFJ6A6MLBDVior9xmnVaPswbYDmomvrrV0decNNPP6mkfnWdE0z NQO3AFvhEm00dmpf3qf0iSExOYchjI/fiswzIaluQaskvB3wx9ZIY5S4xWVsyPMvF0Y0 TkE+qm8OIKrlRlI4oUhoSXeBwEyPAAXTq6sZxYNMS3xHQ5wBtvp0eZ7kSkDJI0fhRjfI ImtoM52DfDp82EZJ6vN+/6dKwOxV6DN4XMxerraFPGb+hge2ljpYb7h/nHybbcfb/YPX XmtvPKoU7NrmTRWa+BSIH6C1X83z43s20Bb99S8s41lM1y5hEE45yyG1Psjq42rnuRf8 JokQ== X-Forwarded-Encrypted: i=1; AJvYcCV8W1/bgFzF07GXSVWDwcex2TLP0czFMdSQ+PnLSo+C6Y25jrH1GEUis/TONbCaT1Rm/0bSdtr0sjrItsg=@vger.kernel.org X-Gm-Message-State: AOJu0YymB8OY1uMnROtSfXIuO9XSPlkke49rg6R1/E5PKDR7iJYv5RTb 2ljLhueh+EbxZ5i+91DBeAx8xNzo9S4brxMgodD8b6OzdurYCI+luZ9a X-Gm-Gg: AZuq6aJfNoTCevPRjBanIrGXjxJaDzucN+M7Cbd2hqH7YSk/PENc1dAu42OVN8BGLdE vdZQ2v8Apmm2VwQGH0lJK3s74+NF8L/iMiO8ivRcebxZ2SoTib4ngboT+fy0OPDdCrSKCROJ5bj UcLgRJYhNKkpzITtjzf79LBSPmFUQw7Uk1g/F1IkByvm3FvIzvw5LYy+GfYYYxklrGWhIlVP1jU QEeH6lCJuvpBsPi5wjmMh54KweDSq5UHfpUe6jzhoWBrXp8BMX70tIL2CHuBUuS8tHZrPB/QqWV gUrgc6IEEXtyCylZ6Yv1NkVzSIzf3lY/39N9KQ4WrciVCdOIjG03DQp+KbPUHWYhvr0LEOBc8v3 JeGzCCRCPYk69HVgJtYtjMfzAxO2/ThWcyuNyfPlFPYqjwF7Za7GVVpe79srXKSbO2I0ZJC3av0 trI+OvDEAH6QYX2t8jCVv42gQ05WXZG6Bsnr8nJ3jTJw== X-Received: by 2002:a05:6000:2283:b0:435:e451:39d4 with SMTP id ffacd0b85a97d-4379792bf73mr26224243f8f.44.1771334904551; Tue, 17 Feb 2026 05:28:24 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ad009bsm33511634f8f.39.2026.02.17.05.28.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 05:28:24 -0800 (PST) Message-ID: Subject: Re: [PATCH v1 1/1] iio: core: Simplify IIO core managed APIs From: Nuno =?ISO-8859-1?Q?S=E1?= To: Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko Date: Tue, 17 Feb 2026 13:29:07 +0000 In-Reply-To: References: <20260216081412.1118599-1-andriy.shevchenko@linux.intel.com> <525a30ed9127b689549bfaedc086638e2e3b5670.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-02-17 at 09:45 +0200, Andy Shevchenko wrote: > On Mon, Feb 16, 2026 at 02:31:57PM +0000, Nuno S=C3=A1 wrote: > > On Mon, 2026-02-16 at 09:14 +0100, Andy Shevchenko wrote: > > > Use devm_add_action_or_reset() instead of devres_alloc() and > > > devres_add(), which works the same. This will simplify the > > > code. There is no functional changes. >=20 > > LGTM. Just one minor "complain". Anyways: >=20 > My answer below. >=20 > > Reviewed-by: Nuno S=C3=A1 >=20 > Thanks! >=20 > ... >=20 > > > - if (!buffer) > > > - return -ENOMEM; > > > + if (IS_ERR(buffer)) > > > + return PTR_ERR(buffer); > >=20 > > Subtle change that could have been mentioned in the commit message. >=20 > Actually not really a change. Currently the error code is shadowed to -EN= OMEM, Well before that was explicit. Now it also depends on the internals of __d= evm_add_action(). That is why I said it was subtle. But yes, no functional change. - Nuno S=C3=A1 >=20