From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DAAB1DE4E4 for ; Fri, 22 Nov 2024 12:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732278427; cv=none; b=BdIGG8wYgQzxel0cSBd1a7Xu4rQLOn2FX1/g5Sc4LlukYJW+1GKRTh4b72mE/2ocXNmTcjXFcDGy7fMX1fMcPP4+tkTLDQ22s0JQhuSPWIABEWU2pgd4Y3kVMaDLWDP7Gd3saC0m/FgXbwD1m1Fxs2ayZdJO8aBDZMdyyEFmWUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732278427; c=relaxed/simple; bh=4aiIpJh+eaWD1gIxrNVIvVmyVJxSvmNVIjIhN4N/AG0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j/F9LLWA3TJOxdA4cnhAXDdlBelhCcPTPz2Nb3uPzphrt39ypPgUjwHbTTGA5Ac58jidcUvVHMS+u7YYt5S4y71ggrOR3x2NWu1f8m+ApF7oC63pDhpgnGUeaWNKs7xvLzS1eYlqub5M0S1mh8H1fHvtmE2qgN2AHn5/VRog0Hg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LikYZeHl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LikYZeHl" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AM9wKvd025504 for ; Fri, 22 Nov 2024 12:27:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +wZgnTIzj6zzY7f1RVOrNUBpDHPvehTTFEmYM7pOCzU=; b=LikYZeHlygIePHea W2zu2mlbFotHL93VjTEWOlsvaRtkmZ2vo/v4hUhRglgAwN2t/arperusDMZbt1Zn 81t0bIRs7+td6oa6IZOKeZkaLLnxM7J8KF7XzAHYSWMVovwS0rNN7wcY86nBeXqC G1wUCrGosXQTQqz+FbA/KPnTVl9iObtRNZIlJO8f4DTAnqvuQWnWZbTcgCcZAekg RKGBb/o//uk9xgMznAu0Z/CAKDalDlNASEPd2yengspNl24eZ9vY/HRdMHdvpPqU JnfPbY1K1ummTCW3agzvWxSDJItJyHislLObTOQ5HxzW9epKvBXfpagWkcggSt7j dFNLWw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 432d5b1we8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 22 Nov 2024 12:27:05 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7b1437d6f6cso25600485a.3 for ; Fri, 22 Nov 2024 04:27:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732278424; x=1732883224; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+wZgnTIzj6zzY7f1RVOrNUBpDHPvehTTFEmYM7pOCzU=; b=SRVCta3qWl3NudJwaf3bdgWa9aw+VOELjXAqedYiElb/guFJgJM1XRsYGOKzIwoCv+ id/TNmmCHldZ4L3OgXy1GXbqYfDMJa3V1DBBZm/iIWNIzWXDB47hduhtdtmXFUByCb0s GO4sBJIwg9MsaX1ln0+adIXW81PEYIOh7zsmrK73HRX8oRxAOS7LIs8ruZskTsSsz4lE wvaWA2zk3M7KD9OOoXQY+zZ8JxBbV6H4steG/qFKlUfuoBnCS3ERyGfn/UiIsIYLJAPy UYCzOrvoZTKsyZmD8qm4LTl/+y1WVO0nsueA4zUr3RHreuwP6tEVGxQCHIk/ZktDJpzp Y2oQ== X-Forwarded-Encrypted: i=1; AJvYcCW27Ltrgxl7qGYWsRmnHV30ImjTqD2V2LIVEgUhhfhBFjGuqI4bBUYxTWImbEhY1TvH9jcXJzFKJJfBNXM=@vger.kernel.org X-Gm-Message-State: AOJu0YxHJnA88zwA9LKvMY801845yMfXMwYp9e7fLCGufEWDEbucYrqX 5J1/QF3SVFubDsdmUb5wXNRw+4nOOpA/YlWLPOahX+czqNn6k+buTyWMiO8AIFCq6q1SQKz75tq 9HsNOHoiMP969OVcl6DDK0cQP3G7onXqXTzqQadMXS1jTWMt4WTCKkDR4c14v4OY= X-Gm-Gg: ASbGncsU0S1+SWtTDRoUbfc6aa1xFYBe4pgr0ma+hx33uv0vTXmOlfbQhCUpVrAiM56 5nnvE2sDrovVbO8wudjz7I9JkhAeXwIbugGmIYYIfccZhlVe5Tdemnr4jqpNwqSTthv3g2WG6VK NnM7o5lr57RgWkKcpSXpdhS51mw8sB415rzOxdG0LuGCyp7KzzGqVXMaOlcCKwJjwDp7NdCZxkp EdYl1+9QUcKwpuY+35AvJuxBqJ6D32Up5DAyUsh4YEk0ExycSnrcVr0ty+DDU2fGMyKtfuqtsfB Pkq71IVe5m8aCDZ6Ln7uzKccF54i5+4= X-Received: by 2002:a05:620a:19a3:b0:7b3:2107:302d with SMTP id af79cd13be357-7b51461660cmr166624585a.16.1732278423883; Fri, 22 Nov 2024 04:27:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGAti18gerkPsJy9ehvlQkHYHYc+es+uoyJF0X67DaPecp+BaAqZTDlar6rEtD5dCOPx62iFg== X-Received: by 2002:a05:620a:19a3:b0:7b3:2107:302d with SMTP id af79cd13be357-7b51461660cmr166622685a.16.1732278423450; Fri, 22 Nov 2024 04:27:03 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa50b28dd83sm95189866b.25.2024.11.22.04.27.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Nov 2024 04:27:03 -0800 (PST) Message-ID: Date: Fri, 22 Nov 2024 13:27:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: qcs615-ride: Enable ethernet node To: Yijie Yang , Andrew Lunn Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20241118-dts_qcs615-v2-0-e62b924a3cbd@quicinc.com> <20241118-dts_qcs615-v2-2-e62b924a3cbd@quicinc.com> <89a4f120-6cfd-416d-ab55-f0bdf069d9ce@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <89a4f120-6cfd-416d-ab55-f0bdf069d9ce@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: qYjrEiH4GTN1kI-7qiuk8YkHXvDb5RwX X-Proofpoint-ORIG-GUID: qYjrEiH4GTN1kI-7qiuk8YkHXvDb5RwX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=834 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411220106 On 19.11.2024 11:09 AM, Yijie Yang wrote: > > > On 2024-11-19 09:27, Andrew Lunn wrote: >> On Mon, Nov 18, 2024 at 02:44:02PM +0800, Yijie Yang wrote: >>> Enable the ethernet node, add the phy node and pinctrl for ethernet. >>> >>> Signed-off-by: Yijie Yang >>> --- >>>   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 106 +++++++++++++++++++++++++++++++ >>>   1 file changed, 106 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts >>> index ee6cab3924a6d71f29934a8debba3a832882abdd..299be3aa17a0633d808f4b5d32aed946f07d5dfd 100644 >>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts >>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts >>> @@ -5,6 +5,7 @@ >>>   /dts-v1/; >>>     #include >>> +#include >>>   #include "qcs615.dtsi" >>>   / { >>>       model = "Qualcomm Technologies, Inc. QCS615 Ride"; >>> @@ -196,6 +197,60 @@ vreg_l17a: ldo17 { >>>       }; >>>   }; >>>   +ðernet { >>> +    status = "okay"; >>> + >>> +    pinctrl-0 = <ðernet_defaults>; >>> +    pinctrl-names = "default"; >>> + >>> +    phy-handle = <&rgmii_phy>; >>> +    phy-mode = "rgmii"; >> >> That is unusual. Does the board have extra long clock lines? > > Do you mean to imply that using RGMII mode is unusual? While the EMAC controller supports various modes, due to hardware design limitations, only RGMII mode can be effectively implemented. Is that a board-specific issue, or something that concerns the SoC itself? > >> >>> +    max-speed = <1000>; >> >> Why do you have this property? It is normally used to slow the MAC >> down because of issues at higher speeds. > > According to the databoot, the EMAC in RGMII mode can support speeds of up to 1Gbps. I believe the question Andrew is asking is "how is that effectively different from the default setting (omitting the property)?" Konrad