From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbcFUPPf (ORCPT ); Tue, 21 Jun 2016 11:15:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43056 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074AbcFUPPd (ORCPT ); Tue, 21 Jun 2016 11:15:33 -0400 Subject: Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support To: Joerg Roedel , Suravee Suthikulpanit References: <1465855611-10092-1-git-send-email-suravee.suthikulpanit@amd.com> <20160621135043.GJ28248@8bytes.org> Cc: rkrcmar@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, sherry.hurwitz@amd.com From: Paolo Bonzini Message-ID: Date: Tue, 21 Jun 2016 17:15:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160621135043.GJ28248@8bytes.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 21 Jun 2016 15:15:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/06/2016 15:50, Joerg Roedel wrote: > The code has a few style issues (thing I'd implemented differently), but > it looks functional. Anyway, before merging this the last 3 patches need > to be acked by the KVM maintainers. > > Paolo? I think patches 9 and 10 should be squashed because the code after patch 9 is only partly functional. Likewise, I think this: + + if (AMD_IOMMU_GUEST_IR_VAPIC(amd_iommu_guest_ir)) + amd_iommu_irq_ops.capability |= (1 << IRQ_POSTING_CAP); from patch 1 should be moved to patch 6. Otherwise the KVM bits are sane. Paolo